gbif / hp-uk-collections

Source for the DiSSCoUK Data Portal provided by GBIF Hosted Portals
https://dissco-uk.org/
2 stars 1 forks source link

Add maps to institution search #22

Closed MortenHofft closed 1 year ago

MortenHofft commented 1 year ago

You mentioned recently that you would like to see a map of institutions, instead of the hardcoded image you have on the landing page.

https://github.com/gbif/hp-uk-collections/blob/928362142f363aa89d99d3fabad2f37e5f151c72/_includes/js/config.js#L105

By changing above line to true a map will be shown in institution search. For now it will only show in your staging environment, but it allows you to test it and see if it is something you would like. I will let you know when it is put into production

lmfrench commented 1 year ago

Thanks, this map looks good, will be happy to have this on the site once it is ready for production

lmfrench commented 1 year ago

I've noticed a couple of institutions which appear in the wrong location:

MortenHofft commented 1 year ago

The coordinates comes from the latitude longitude fields. I've asked IH to fix "Herbarium - Cornwall College" as they maintain that information https://registry.gbif.org/collection/916e4c05-7c32-40f9-a469-88770a271729.

You might want to do the same, it isn't data that we can manage directly as IH is listed as the master source. Alternatively it could be decoupled from Index Herbariorum and managed directly in GrSCiColl. @manongros can advice better than I

MortenHofft commented 1 year ago

Thanks, this map looks good, will be happy to have this on the site once it is ready for production

The code is in production, so it is up to you when you want to enable it.

lmfrench commented 1 year ago

@ManonGros We had a look and the University of Aberdeen lat/long fields are also coming from IH. We are going to remove IH as the master source for both of those records and update it

Thanks again Morten - once we have updated those records I will make this feature live on the site, it looks great and we will share it with the DiSSCo UK network. I'll add an FAQ to the site to explain to people how to update their lat/long in GrSCiColl in case there are any other errors we haven't noticed.

MortenHofft commented 1 year ago

I've left a few automated suggestions for location updates, as well as a few for dead home page links For example: https://registry.gbif.org/institution/5856795e-02c7-49ee-9c26-dddfb7b8f68a?suggestionId=1064 By clicking "show in form" you can see the map and possible correct the suggestion location.

@lmfrench looks like I can generate coordinate suggestions for around 40 more institutions. Let me know if you would like me to do so

ManonGros commented 1 year ago

Hi @lmfrench, if you can forward correction to IH, I am sure it would be appreciated. Otherwise, feel free to disconnect institution entries from IH (this shouldn't be a problem). If you need to disconnect collection entries from IH for one reason or another, please contact me by email. Thanks!

lmfrench commented 1 year ago

@MortenHofft I tried to make this feature live earlier, but it is not showing on the site. It does work on the staging site.

This was the code I changed: https://github.com/gbif/hp-uk-collections/blob/949bf4e8ec8f89974048f3e89f7255a47e919a09/_includes/js/config.js#L105

MortenHofft commented 1 year ago

It hadn't been deployed to production, despite what I wrote above. Clearly I needed vacation. I am back and the code is in production and visible here https://data.dissco-uk.org/institution/search Sorry about that.

lmfrench commented 1 year ago

Thanks a lot, all working - hope you enjoyed the break!