gbif / ipt

GBIF Integrated Publishing Toolkit (IPT)
https://www.gbif.org/ipt
Apache License 2.0
127 stars 58 forks source link

Minor styling bugs or enhancements following styling and template refactor (r3736) #878

Closed kbraak closed 9 years ago

kbraak commented 9 years ago
I will detail each bug or enhancement needed in a separate comment, accompanied with
a screenshot. 

Original issue reported on code.google.com by kyle.braak on 2012-06-06 07:54:49

kbraak commented 9 years ago
Resource's list header, and description text are too close to the left. 

See screenshots showing old ipt.gbif.org, vs new version

Original issue reported on code.google.com by kyle.braak on 2012-06-06 07:57:14


kbraak commented 9 years ago
Edit buttons do not align on manage resource page

Chrome, v. r3744    

Original issue reported on code.google.com by kyle.braak on 2012-06-06 07:58:34


kbraak commented 9 years ago
It appears as if the 2nd column of information in the manage resource page is shifted
very far to the right, because of the 1st column's row "A new EML version has been
published"

I would prefer shortening the row's text, shifting the 2nd column back to the left,
thereby minimizing the space between the 1st and 2nd columns a bit. 

Original issue reported on code.google.com by kyle.braak on 2012-06-06 08:02:58


kbraak commented 9 years ago
The margin or padding should be uniform on both sides of the Action message (green)
or Warning messages (yellow) or Error messages (red). Please see the attached screenshot.
Notice all the padding on the right side.

Original issue reported on code.google.com by kyle.braak on 2012-06-06 12:44:08


kbraak commented 9 years ago
Some strange styling around source file specifications. Compare snapshots, one of which
is from ipt.gbif.org to show you the existing format

Original issue reported on code.google.com by kyle.braak on 2012-06-06 14:32:36


kbraak commented 9 years ago
On add organization page, the password field and save button are way to big. Please
take a look at the attached screenshot. 

Original issue reported on code.google.com by kyle.braak on 2012-06-06 14:37:51


kbraak commented 9 years ago
Improve size and quality of GBIF logo. Previously it was larger and was better quality.
Please see attached screenshots of before and after

Original issue reported on code.google.com by kyle.braak on 2012-06-06 14:48:36


kbraak commented 9 years ago
On source preview, the preview is shown below the footer. It should replace the original
window instead, like it did in 2.0.3. Please see the screenshot attached. 

Original issue reported on code.google.com by kyle.braak on 2012-08-02 13:33:04


kbraak commented 9 years ago
The singe extension page (click on the name of any installed extension listed on the
core types and extensions page) has various styling inconsistencies between the old
and new styling. Please see the attached screenshot.  

Original issue reported on code.google.com by kyle.braak on 2012-08-02 13:37:39


kbraak commented 9 years ago
(No text was entered with this change)

Original issue reported on code.google.com by kyle.braak on 2012-08-02 19:11:19

kbraak commented 9 years ago
(No text was entered with this change)

Original issue reported on code.google.com by kyle.braak on 2012-08-07 08:51:10

kbraak commented 9 years ago
The save button on setup page 2 is extremely small, please take a look at the attached
screenshot. 

Original issue reported on code.google.com by kyle.braak on 2012-08-08 09:24:57


kbraak commented 9 years ago
Buttons on translation page have different sizes: see screenshot

Original issue reported on code.google.com by kyle.braak on 2012-08-14 15:21:00


kbraak commented 9 years ago
Problem with translation page buttons fixed in r3952. 

Original issue reported on code.google.com by kyle.braak on 2012-08-16 10:50:48

kbraak commented 9 years ago
Two irregular edit buttons that appear in comment 2 have been updated to look like other
buttons in r3953. 

Original issue reported on code.google.com by kyle.braak on 2012-08-16 14:19:33

kbraak commented 9 years ago
At least the buttons are fixed on Comment 6 (add organization page) in r3955

Original issue reported on code.google.com by kyle.braak on 2012-08-16 15:28:52

kbraak commented 9 years ago
Comment 9 addressed as r3970.

Original issue reported on code.google.com by bko@gbif.org on 2012-08-23 13:26:14

kbraak commented 9 years ago
Comment 8 addressed as r3973.

Original issue reported on code.google.com by bko@gbif.org on 2012-08-23 14:00:06

kbraak commented 9 years ago
Comment 5 addressed as r3972.

Original issue reported on code.google.com by bko@gbif.org on 2012-08-23 14:00:46

kbraak commented 9 years ago
Regarding the new column layout for the extension page, resource home page, vocab page,
etc.. please see the attached screenshot. 

Why is the Title in the left hand (shaded box) sometimes in the middle and sometimes
up top? Can it please always be at the top?

Original issue reported on code.google.com by kyle.braak on 2012-08-24 08:14:21


kbraak commented 9 years ago
On the resource home page, a large logo is displayed at the top now in its own section
by itself. Before, the text in the description used to wrap around it and extend to
the full width of the page. Please see a comparison of new vs old styling. To simulate
yourself, you can download and import this resource from Canadensys: http://data.canadensys.net/ipt/resource.do?r=acad-specimens

Original issue reported on code.google.com by kyle.braak on 2012-08-24 08:16:37


kbraak commented 9 years ago
I need to look into this more (not sure if it is styling or template related) but there
is a floating taxonomic coverage that gets improperly displayed - see highlighted portion
of screenshot. 

It should be appended to the family list. 

Original issue reported on code.google.com by kyle.braak on 2012-08-24 08:26:20


kbraak commented 9 years ago
On Chrome 21.0.1180.82 the save and cancel button on the basic metadata page appear
all the way at the top. It should be at the bottom. Please see the attached screenshot.
If I zoom in or out of the page, the buttons actually move to the bottom of the page
where they should be - strange. 

Original issue reported on code.google.com by kyle.braak on 2012-08-27 08:57:07


kbraak commented 9 years ago
Please see my update to this issue also: Issue 838

Original issue reported on code.google.com by kyle.braak on 2012-08-27 08:58:22

kbraak commented 9 years ago
There's no reason each user can't be on a single line, wouldn't you agree? Please see
that attached screenshot. Thanks

Original issue reported on code.google.com by kyle.braak on 2012-08-27 12:00:36


kbraak commented 9 years ago
The delete button on the edit user page is enormous. Please see screenshot taken from
Chrome + my mac. 

Original issue reported on code.google.com by kyle.braak on 2012-08-27 12:02:38


kbraak commented 9 years ago
This issue was updated by revision r4007.

Original issue reported on code.google.com by kyle.braak on 2012-08-28 13:44:34

kbraak commented 9 years ago
You can ignore Comment 22, it has been fixed in r4007. 

Original issue reported on code.google.com by kyle.braak on 2012-08-28 13:45:18

kbraak commented 9 years ago
There is an enormous amount of space between the sections in the show only mapped fields
sections. Please see attached screenshot. 

Original issue reported on code.google.com by kyle.braak on 2012-08-29 14:07:53


kbraak commented 9 years ago
A single large extension title makes the manage overview page look quite out of shape.
Can we please fix the width of the drop down here? Please see screenshot: 

Original issue reported on code.google.com by kyle.braak on 2012-08-30 13:43:35


kbraak commented 9 years ago
Some additional things with the public resource page that don't look very pleasing:
the associated parties and citations sections. Please see screenshots. You can use
the attached eml.xml to reproduce the view. 

Original issue reported on code.google.com by kyle.braak on 2012-08-31 14:27:09


kbraak commented 9 years ago
Source page looks rather weird in traditional Chinese, please see screenshot. Is this
ok Burke?

Original issue reported on code.google.com by kyle.braak on 2012-09-06 13:13:04


kbraak commented 9 years ago
All comments addressed as r4035.

Original issue reported on code.google.com by bko@gbif.org on 2012-09-07 14:08:43

kbraak commented 9 years ago
unnecessary halfcolumn container. addressed as r4037.

Original issue reported on code.google.com by bko@gbif.org on 2012-09-11 09:45:09


kbraak commented 9 years ago
The issue in comment 32 was fixed as r4038. The word wrap of file path is also fixed.
The key is to use max-width property for the <td> tag.

Original issue reported on code.google.com by bko@gbif.org on 2012-09-11 09:54:43


kbraak commented 9 years ago
Right floating core mapping box on Firefox, see imaged. Fixed as r4039.

Original issue reported on code.google.com by bko@gbif.org on 2012-09-12 10:24:52


kbraak commented 9 years ago
Mapping page had the title link to the resource overview with the name of the source
data file. To correct this and make it more reasonable. We link the title to resource
overview with resource name, arrange the "mapping source data" section to the top with
link to source data file, and put the "core type section" below "mapping source data"
section.

Provided as r4041.

Original issue reported on code.google.com by bko@gbif.org on 2012-09-13 10:05:44


kbraak commented 9 years ago
Further to comment 20, in Opera and Firefox, the title in the left hand column on the
public resource page is completely in the wrong section (see screenshot). Only in Chrome
does it appear alright. 

The resource's eml.xml file used to reproduce the problem is also attached. 

Original issue reported on code.google.com by kyle.braak on 2012-09-15 16:06:04


kbraak commented 9 years ago
Comment 38 fixed as r4050. 

Original issue reported on code.google.com by bko@gbif.org on 2012-09-15 18:43:40


kbraak commented 9 years ago
Almost every "add new .. " link is shifted to the right. It should be aligned with the
left margin. See screenshot demonstrating problem. 

Original issue reported on code.google.com by kyle.braak on 2012-09-18 15:06:07


kbraak commented 9 years ago
Comment 40 is fixed as r4070. There was no wrapper for the link, now provided.

Original issue reported on code.google.com by bko@gbif.org on 2012-09-18 15:33:24

kbraak commented 9 years ago
I have just updated, one more at least. See screenshot. It is on the taxonomic coverage
page. 

Original issue reported on code.google.com by kyle.braak on 2012-09-18 16:15:00


kbraak commented 9 years ago
Fixed as r4075. All metadata templates have been reviewed. Those unnecessary new line
containers, which mostly had been removed as r3736, are cleaned in this commit. Relevant
<a> now wrapped with a container with class="addNew". Please check.

Original issue reported on code.google.com by bko@gbif.org on 2012-09-19 09:08:05

kbraak commented 9 years ago
New issue. Seems like the add new should be on a separate line from the field - see
screenshot showing crowding. 

Original issue reported on code.google.com by kyle.braak on 2012-09-19 12:08:45


kbraak commented 9 years ago
Is it really necessary that the unmapped section has a horizontal scrollbar? Please
see screenshot. Thanks

Original issue reported on code.google.com by kyle.braak on 2012-09-20 14:48:19


kbraak commented 9 years ago
Fixed word breaking of source file table in IE9.
Fixed word breaking of extension page.
Fixed group title being pushed to the right of buttons.
Fixed the horizontal scrollbar in the unmapped columns section.
One round check in IE9.
Cmt 44 to be resolved.
See r4096.

Original issue reported on code.google.com by bko@gbif.org on 2012-09-20 17:08:40

kbraak commented 9 years ago
Cmt 44 fixed in 4097.

Original issue reported on code.google.com by bko@gbif.org on 2012-09-21 09:21:12

kbraak commented 9 years ago
A bit of padding is needed on the manage overview page left column. The titles are stuck
to the left edge. Please see screenshot.

Original issue reported on code.google.com by kyle.braak on 2012-09-24 09:19:08


kbraak commented 9 years ago
Amen - I think the grey containers should align to the left with the headlines/title
of the archive.  

Original issue reported on code.google.com by klegind on 2012-09-24 09:25:29

kbraak commented 9 years ago
Cmn 48 and 49 addressed in r4105. Padding is recovered.

Original issue reported on code.google.com by bko@gbif.org on 2012-10-02 10:50:40