gbif / ipt

GBIF Integrated Publishing Toolkit (IPT)
https://www.gbif.org/ipt
Apache License 2.0
127 stars 57 forks source link

Minor styling bugs in 2.0.4 #934

Closed kbraak closed 9 years ago

kbraak commented 9 years ago
Please use this issue to report any styling errors encountered in the 2.0.4 version
of the IPT. Thanks

Original issue reported on code.google.com by kyle.braak on 2012-10-29 17:34:50

kbraak commented 9 years ago
Transferred from Issue 878: Comment 104 by project member daniel.amariles88, Oct 26
(2 days ago)

Problems in Source Data page
 * not showing preview button
 * delete button is shown too lower

Tested in 
IPT Version 2.0.5-SNAPSHOT-r4235
IPT Version 2.0.4 (tag version)

It happens
Chrome 22.0.1229.94 m for Windows

Doesn't happen in 
Chrome 20.0.1132.57 for MacOSX 
Firefox 14.0.1 for MacOSX
Firefox 16.0.1 for Windows

Please note: this could be related with issue 933

Original issue reported on code.google.com by kyle.braak on 2012-10-29 17:37:21


kbraak commented 9 years ago
Our webdesigner Carlos
suggested to change some lines of the css

currently the style have this:

.buttons{
height:25px;
margin-top:10px;
float:left;
}

and the suggestion is set following lines:

.buttons{
margin-top:10px;
float:left;
min-width:200px;
}

thanks

Original issue reported on code.google.com by daniel.amariles88 on 2012-10-30 16:08:52

kbraak commented 9 years ago
This issue was updated by revision r4237.

Original issue reported on code.google.com by kyle.braak on 2012-11-01 20:19:48

kbraak commented 9 years ago
Thanks for the contribution. After testing browsers on OS X I found no errors with the
way buttons render and committed it in r4237.

I will need your help testing browsers on Windows, to see if buttons render, and if
Issue 933 has been solved as a result of the change... would that be possible? Many
thanks

Original issue reported on code.google.com by kyle.braak on 2012-11-01 20:27:58

kbraak commented 9 years ago
*Transferred comment by s.cozijnsen made in http://code.google.com/p/gbif-providertoolkit/source/detail?r=4238
to this issue:

/trunk/gbif-ipt/src/main/webapp/WEB-INF/pages/portal/home.ftl   r4238   line 52:
52:           ${r.coreType?upper_case}

Suggestion: change ${r.coreType?upper_case} to ${r.coreType?lower_case} and handle
the styling in the main.css.

 table td#resourceType, table td#resourceSubType {
    text-transform: uppercase;
}

The reason for this would be that you can also choose "capitalize" so that all the
columns have the same styling. (see: http://ipt.nlbif.nl )

/trunk/gbif-ipt/src/main/webapp/WEB-INF/pages/portal/home.ftl   r4238   line 59:
59:           ${r.subtype?upper_case?substring(0,7)}${dotDot}

Suggestion: change ${r.subtype?upper_case?substring(0,7)}${dotDot} to ${r.subtype?lower_case?substring(0,7)}${dotDot}
and handle the styling in the main.css.

Same reason as described earlier.

Sijmen

Original issue reported on code.google.com by kyle.braak on 2012-11-05 11:46:48

kbraak commented 9 years ago
This issue was updated by revision r4239.

Original issue reported on code.google.com by kyle.braak on 2012-11-06 09:42:44

kbraak commented 9 years ago
sorry for the delay

we tested, and still being a difference between chrome and firefox
the "Delete source file" button appears a line above the "Save" and "Cancel" buttons
 (see  screenshots)

Original issue reported on code.google.com by daniel.amariles88 on 2012-11-07 14:02:56


kbraak commented 9 years ago
Daniel, any patches from your styling experts are more than welcome. Please report any
additional styling problems if you find them. Thanks.

Original issue reported on code.google.com by kyle.braak on 2013-03-19 16:33:21

kbraak commented 9 years ago
with changes specified in comment #2 we fixed in our fork the specified in comment #8

styling enhancements may be adopted from our repository
we sugest to checkout our green version trunk/verde-ipt-2.0.4
http://code.google.com/p/sib-ipt/source/browse/#svn%2Ftrunk%2Fverde-ipt-2.0.4
please, feel free to use anything there

Original issue reported on code.google.com by daniel.amariles88 on 2013-03-20 16:34:31

kbraak commented 9 years ago
I suggest to use our administration icons (see attachment) shared in repository shared
in comment 10

Original issue reported on code.google.com by daniel.amariles88 on 2013-04-09 22:41:04


kbraak commented 9 years ago
I suggest to change the marker icon from geocoverage page
by setting in geocoverage.ftl a local image path in the "markerIcon" variable, like:
      var markerIcon = '../images/icons/dot.png';
and adding adding a nicer image for marker (see attachment downloaded from Maki http://mapbox.com/maki/)

Original issue reported on code.google.com by daniel.amariles88 on 2013-04-09 22:48:14


kbraak commented 9 years ago
another suggestion is to change the language selection menu, to show the name of the
language instead of the flags of a single country, see attachment.

Original issue reported on code.google.com by daniel.amariles88 on 2013-04-10 19:38:35


kbraak commented 9 years ago
Daniel - the suggestion looks cool!
About the language selector, there is a separate issue that I'd like to bring to the
attention of issue-subscribers.
http://code.google.com/p/gbif-providertoolkit/issues/detail?id=729

Original issue reported on code.google.com by bko@gbif.org on 2013-04-16 14:04:09

kbraak commented 9 years ago
This issue was updated by revision r4348.

Original issue reported on code.google.com by kyle.braak on 2013-05-14 09:49:14

kbraak commented 9 years ago
New admin icons added as per suggestion. See screenshot. Main colors made consistent
across pages. See 2nd screenshot.

Original issue reported on code.google.com by kyle.braak on 2013-05-14 09:55:45


kbraak commented 9 years ago
I don't intend on making further changes to the style now. New issues can be opened
up agains 2.0.5 when it is released. 

Verified.

Original issue reported on code.google.com by kyle.braak on 2013-05-16 10:30:19