search

gbif / name-parser

The core GBIF scientific name parser library
Apache License 2.0
18 stars 4 forks source link

Replace logback-test.xml with logback.xml #84

Closed qifeng-bai closed 2 years ago

qifeng-bai commented 2 years ago

logback-test.xml has a higher priority than logback.xml. Using logback-test.xml prevents the other libs for load logback.xml

LA-pipelines report:

WARN in ch.qos.logback.classic.LoggerContext[default] - Resource [logback-test.xml] occurs at [jar:file:/~/.m2/repository/org/gbif/name-parser-api/3.1.11/name-parser-api-3.1.11-tests.jar!/logback-test.xml]

Further investigation:

I was working on org.gbif.pipelines: 2.10.0-SNAPSHOT version/branch - two weeks behind current dev branch

org.gbif.pipelines - org.gbif.gbif-parsers: 0.54 - org.gbif.name-parser-api - 3.1.11

After I pull the dev branch, the pipelines uses:

- org.gbif.gbif-parsers: 0.57-snapshot - org.gbif.name-parser-api - 3.7.1-snapshot

This issue is solved

timrobertson100 commented 2 years ago

Thanks QBai

Can you elaborate on where this causes issue please? The original design was presumably to allow a different logging configuration for the testing, which should only get into the *-tests.jar.

Is it causing an issue in your test setup, or is this jar somehow getting onto your running app classpath?

Thanks

On 16 Dec 2021, at 04:37, QBai @.***> wrote:

 logback-test.xml has a higher priority than logback.xml. Using logback-test.xml prevents the users to load logback.xml

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

mdoering commented 2 years ago

Neither logback.xml nor logback-test.xml is included in the main resources. It is just for tests. Can you explain the issue please?

qifeng-bai commented 2 years ago

In ALA pipelines, we cannot get our logback.xml loaded, unless we use logback-test.xml. We found:

WARN in ch.qos.logback.classic.LoggerContext[default] - Resource [logback-test.xml] occurs at [jar:file:/~/.m2/repository/org/gbif/name-parser-api/3.1.11/name-parser-api-3.1.11-tests.jar!/logback-test.xml]

I worked on org.gbif.pipelines: 2.10.0-SNAPSHOT version/branch - two weeks behind current dev branch

org.gbif.pipelines

After I pull the dev branch, the pipelines uses:

This issue is solved

Thanks all