gbif / name-parser

The core GBIF scientific name parser library
Apache License 2.0
18 stars 4 forks source link

Salmonidae Jarocki or Schinz, 1822 #98

Closed mdoering closed 10 months ago

mdoering commented 11 months ago

Family Salmonidae Jarocki or Schinz, 1822 parses wrongly and considers or a species epithet. http://api.checklistbank.org/parser/name?q=Salmonidae%20Jarocki%20or%20Schinz,%201822

timrobertson100 commented 11 months ago

Found in xcol impact report where a lookup returns this (note it's OK in the name, but not in the classification):

{
  "synonym": false,
  "usage": {
    "key": 217387516,
    "name": "Salmonidae Jarocki or Schinz, 1822",
    "rank": "FAMILY"
  },
  "classification": [
    {
      "key": 214215335,
      "name": "Animalia",
      "rank": "KINGDOM"
    },
    {
      "key": 217148636,
      "name": "Chordata",
      "rank": "PHYLUM"
    },
    {
      "key": 217387493,
      "name": "Salmoniformes",
      "rank": "ORDER"
    },
    {
      "key": 217387516,
      "name": "Salmonidae or",
      "rank": "FAMILY"
    }
  ],
  "diagnostics": {
    "matchType": "EXACT",
    "confidence": 100,
    "status": "ACCEPTED",
    "lineage": [],
    "alternatives": [],
    "note": "All provided names were ignored since the usageKey was provided"
  }
}
timrobertson100 commented 11 months ago

Can you please deploy it on http://backbonebuild-vh.gbif.org:9000/species/match2?usageKey=217387516 when it makes sense to (perhaps with the next release if that is soon)?

mdoering commented 11 months ago

done

timrobertson100 commented 11 months ago

I'm afraid the lookup still has:

{
"key": 217387516,
"name": "Salmonidae or",
"rank": "FAMILY"
}
mdoering commented 11 months ago

well, that is a data issue, not parser. This would only be fixed when we had a new release with new data - and I would actually have to make sure we update/sync the source that contributed the family name.

I thoought the problem was in parsing the request data.