search

gbif / parsers

Various GBIF parsers for dates, countries, language, taxon ranks, etc
Apache License 2.0
4 stars 8 forks source link

Support KM-to-Metre conversion #21

Closed qifeng-bai closed 4 years ago

qifeng-bai commented 4 years ago

At this moment, MeterRangeParser is able to convert inch/feet to meters. We also need to 1, support conversion of KM to meters. 2, support patterns of km, kilometers, kilometres, feet, f, inch, inches

MattBlissett commented 4 years ago

Is it necessary to support f alone, or was that just an idea? I see extremely few cases of this unit in GBIF's data, and it's ambiguous with fathoms (which I've added).

I'll merge the PR without f for the moment.

mdoering commented 4 years ago

Isn't ft used as a short version for feet?

qifeng-bai commented 4 years ago

Isn't ft used as a short version for feet?

ft is already supported. @MattBlissett I am OK without 'f'. I followed what Biocache does.

MattBlissett commented 4 years ago

OK, then this is completed. (Markus, ft is included in the change.)

You can use version 0.52-SNAPSHOT in pipelines, and we'll release it when it's necessary to release pipelines. (I think there will be some other minor changes to parsers this week.)