search

gbif / portal-feedback

User feedback for the GBIF API, website and published data. You can ask questions here. 🗨❓
30 stars 16 forks source link

Species pages should not link to non existing tabs #3660

Open gbif-portal opened 3 years ago

gbif-portal commented 3 years ago

Species pages should not link to non existing tabs

https://www.gbif.org/species/7261959/treatments this page has a treatment. When the user navigates in the classification drawer, to e.g. subspecies "Rhinolophus sinicus subsp. septentrionalis Sanborn, 1939", then we link to the treatment page despite it being non existing. Leading to an empty page. That confused me to the point I thought we had a larger bug or an API outage.

Github user: @MortenHofft User: See in registry System: Chrome 94.0.4606 / Mac OS X 10.15.7 Referer: https://www.gbif.org/species/7261959/treatments Window size: width 1440 - height 762 API log&_a=(columns:!(_source),filters:!(),index:'3390a910-fcda-11ea-a9ab-4375f2a9d11c',interval:auto,query:(language:kuery,query:''),sort:!())) Site log&_a=(columns:!(_source),filters:!(),index:'5c73f360-fce3-11ea-a9ab-4375f2a9d11c',interval:auto,query:(language:kuery,query:''),sort:!())) System health at time of feedback: WARNING

MortenHofft commented 3 years ago

If we want to link to a treatment tab (and we cannot know up front if it is there), then I suggest we put a message on that page. We do something similar for country pages if the country isn't a participant but we somehow link to a non existing page. https://www.gbif.org/country/CN/participation

We could also consider adding the active tab (and remove it again when the user moves to another tab) - but I would have to see it to tell if it is confusing.