search

gbif / portal-feedback

User feedback for the GBIF API, website and published data. You can ask questions here. 🗨❓
30 stars 16 forks source link

Species name wrongly shown in browser page/tab title #4734

Open gbif-portal opened 1 year ago

gbif-portal commented 1 year ago

Species name wrongly shown in browser page/tab title

Instead of Uma rufopunctata Cope, 1895 the according to part fide Smith & Taylor, 1950 is shown.

image

User: See in registry - Send email System: Safari 16.2.0 / Mac OS X 10.15.7 Referer: https://www.gbif.org/species/185106099/verbatim Window size: width 1511 - height 866 API log&_a=(columns:!(_source),filters:!(),index:'3390a910-fcda-11ea-a9ab-4375f2a9d11c',interval:auto,query:(language:kuery,query:''),sort:!())) Site log&_a=(columns:!(_source),filters:!(),index:'5c73f360-fce3-11ea-a9ab-4375f2a9d11c',interval:auto,query:(language:kuery,query:''),sort:!())) System health at time of feedback: OPERATIONAL

MortenHofft commented 1 year ago

Hi @mdoering

The browser tab shows the full scientific name provided by the API: https://api.gbif.org/v1/species/185106099 which is "scientificName": "Uma rufopunctata Cope, 1895 () fide Smith & Taylor, 1950". I would think that is the correct thing to do?

The bug seem to me in the method that does the italicising in the title, that rewrites the name. @thomasstjerne shouldn't this respect the name, and only add italics? It seems odd that it rewrites the name provided by the publisher. Especially for non-backbone checklists?

mdoering commented 1 year ago

Hm indeed this looks fine. I strongly remember only to have seen "fide Smith & Taylor, 1950". But maybe that was due to many open tabs and something got cut off by the browser itself.

thomasstjerne commented 1 year ago

The formatter uses the canonical name, author and year from this endpoint: https://api.gbif.org/v1/species/185106099/name Seems it does not respect the sensu part though