search

gbif / portal-feedback

User feedback for the GBIF API, website and published data. You can ask questions here. 🗨❓
30 stars 16 forks source link

Not a treatment article #5432

Open gbif-portal opened 2 months ago

gbif-portal commented 2 months ago

Not a treatment article

Not all checklist datasets from Pensoft contain treatments. This dataset here is a simple checklist of names. The title "treatment article" is misleading.

User: See in registry - Send email System: Safari 17.6.0 / Mac OS X 10.15.7 Referer: https://www.gbif.org/dataset/655027fc-76ea-447a-a443-f36dd2e853d7 Window size: width 1759 - height 915 API log&_a=(columns:!(_source),filters:!(),index:'3390a910-fcda-11ea-a9ab-4375f2a9d11c',interval:auto,query:(language:kuery,query:''),sort:!())) Site log&_a=(columns:!(_source),filters:!(),index:'5c73f360-fce3-11ea-a9ab-4375f2a9d11c',interval:auto,query:(language:kuery,query:''),sort:!())) System health at time of feedback: OPERATIONAL

MortenHofft commented 2 months ago

Thanks @mdoering I'm not sure what to do here. We do not model treatments. In the gbif.org backend we modify the response subtype to TREATMENT_ARTICLE if from a fixed list of publishers. I'm not sure what the ideal scenario is, but adding a new subtype that was actually controlled by the dataset metadata and not the publisherKey could be one way.

For now all I can do is to remove the "feature". What do we prefer? I'm not keen on going through more frontend loops of trying to figure out if the dataset is of a special type. It ought to live in the data/APIs so that everyone - including future iterations of gbif.org - benefit from it.

mdoering commented 2 months ago

We should try to set the right TREATMENT_ARTICLE subtype in the backend / registry. Do you know where exactly this is being set? There is no subtype for this dataset in the API response: https://api.gbif.org/v1/dataset/655027fc-76ea-447a-a443-f36dd2e853d7

MortenHofft commented 2 months ago

In the gbif.org backend we modify the response subtype to TREATMENT_ARTICLE if from a fixed list of publishers.

We add this subtype in the front end project if from a plazi or pensoft. It is a hack (prompted by a request to highlight treatments) because we do not model this in the API. It doesn't exists https://api.gbif.org/v1/enumeration/basic/DatasetSubtype - I did it this way, because if we then decide to add the subtype, then it would be easy to remove my hack and have proper managed data

MortenHofft commented 2 months ago

See also https://github.com/gbif/registry/issues/107