gbif / portal16

GBIF.org website
https://www.gbif.org
Apache License 2.0
24 stars 15 forks source link

Directory of contacts - a few issues from Admin #157

Closed dnoesgaard closed 7 years ago

dnoesgaard commented 7 years ago

Admin has raised a few issues in the directory:

dnoesgaard commented 7 years ago

(@kcopas, just fyi...)

kcopas commented 7 years ago

Logging a request for adjustment/refinement of the same page, please—

In the list of the Secretariat contacts, can we please cluster an initial view/sort that shows DH at the top, followed by the four heads of groups (alpha order of last name? Hahn, Hirsch, Nielsen, Robertson) and then an alphabetical listing of all other staff?

Don't know whether updating titles in the directory will update the current display to this or whether other adjustments are in order, but given that I've consulted DH and TH on this, it would be good to implement this for v1.

ckotwn commented 7 years ago

The missing roles looks like content issue to me. Correct me if I am wrong.

As to sorting, @MortenHofft & @cgendreau is it better to have that done from the report endpoint, or to sort them at the Express end?

MortenHofft commented 7 years ago

The missing roles looks like content issue to me. Correct me if I am wrong.

I would assume the same, but cannot say without looking in the Directory. And no access from here.

As to sorting, is it better to have that done from the report endpoint, or to sort them at the Express end?

How does it work now? They are already sorted it seem? The first is Donald, Anne mette and Tim R. then alpha. So someone somewhere is doing a custom sort i would guess. I would suggest updating that to reflect Hahn and Hirsh. And if you aren't sorting it in express Burke, then Christian is sorting already (unless the alphabetical ordering is by chance).

cgendreau commented 7 years ago

There is a sort in the backend but I can't remember at which level exactly.

dnoesgaard commented 7 years ago

The missing roles looks like content issue to me. Correct me if I am wrong.

take Dag Endresen for example. He's the node manager of Norway, and listed as such in the directory: http://directory.gbif.org/#/people/74

He, however, has no role in the Nodes committee section of the directory of contacts page.

cgendreau commented 7 years ago

I fixed the Secretariat contacts order. For the missing roles I can confirm the Directory API returns the expected result so it should not be a data issue. They all seem to have links with node AND participant (or GBIF role) so I would have a look at the "de-duplication" code in the frontend.

kbraak commented 7 years ago

@MortenHofft IMHO this issue should be labelled as a release blocker. Showing the correct role for contacts in our network is fundamental.

MortenHofft commented 7 years ago

this page have been reimplemented. Admin has approved that the issues has been fixed