gbif / rs.gbif.org

GBIF machine-readable resources
https://rs.gbif.org
12 stars 12 forks source link

replace obsolete term wiki URLs with permanent Audubon Core termlist URLs #41

Closed baskaufs closed 3 years ago

baskaufs commented 4 years ago

As noted in https://github.com/tdwg/ac/issues/160, the links to Audubon Core documentation in the GBIF Audubon Core Media Description document link to the deprecated Terms Wiki pages that are no longer maintained. This pull request changes those URLs to the permanent URLs for the Audubon Core term list page. These URLs should not change even if there is a redirect to a different site that hosts the metadata.

baskaufs commented 3 years ago

Ping @timrobertson100 @MattBlissett

timrobertson100 commented 3 years ago

Thanks @baskaufs

These files are immutable, and tools like the IPT cache them, keyed on the URL. While these changes don't affect the functionalities, I think it would be good practice to follow the versioning approach we promote.

Unless you really do want to push this through, knowing that people will see differing information can you please modify it with the deprecation approach? See the resource relation as an example (versioned filename with correct "issued" date).

In future, please do not hesitate to ping @MattBlissett @mdoering or @timrobertson100 when opening PRs on this repo. We have so many repositories underway sometimes things go unnoticed.

baskaufs commented 3 years ago

@timrobertson100 How about this? I tried to follow the resource relation pattern.

This seems completely backwards from what I've seen elsewhere. In places like the W3C, the unversioned "latest version" URI redirects to the most recent version and the versioned resources are maintained of all prior versions. See https://www.w3.org/TR/xml/ for example. I don't understand how a client will have any idea that the file has been updated to a new version. But whatever, I don't know how you operate at GBIF.

timrobertson100 commented 3 years ago

This seems completely backwards from what I've seen elsewhere

~Probably, but the IPT was developed in 2009... it can be changed but there is a layer of redirection in a registry that the IPT uses that will need to be addressed.~

I think there are two things actually

  1. The IPT uses a registry lookup which could probably be changed.
  2. There is legacy data (DwC-A) that is mapped to the data structures, where the data structure is defined by the schema on the URI. If that is mutable, then I think it becomes impossible to know the schema to which the data is mapped.

Bear in mind this stuff goes back 10+ years so we don't want to break that.