Closed tucotuco closed 3 years ago
Note: these terms should also be added to the distribution extension. Will see if I can do that tomorrow.
While you are at it, check the definitions of other terms. The Occurrence Core was out of date back to 2015 in this respect.
On Sun, Oct 25, 2020 at 5:41 PM Peter Desmet notifications@github.com wrote:
Note: these terms should also be added to the distribution extension. Will see if I can do that tomorrow.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gbif/rs.gbif.org/pull/46#issuecomment-716208688, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADQ72667YL4YMHPWAICUZTSMSEO7ANCNFSM4S56RSSQ .
Oh, I don't have write access to your branch of course. No matter, I think it makes more sense to do this as two pull requests anyway. What do you mean "check the definition of other terms"? You mean of the distribution extension?
Thank you.
While you are exploring these, can you please also cast an eye over the event core and see if any of the terms common in both need to be addressed there?
We need to test the implications of this in a test IPT and the UAT crawling in GBIF before we merge this to production. Can you please target the sandbox environment for the PR so we can then start an IPT testing phase? A second PR will be used to move it from sandbox to production (by @MattBlissett or myself) and reviewed as an additional step.
Now created a sister PR at https://github.com/gbif/rs.gbif.org/pull/47
@timrobertson100 should we just do all this in the sandbox environment, ideally on the same branch? @tucotuco and I can coordinate
@timrobertson100 do you want us to create/copy the newly adopted controlled vocabularies for these terms in http://rs.gbif.org/vocabulary/gbif/ or http://rs.gbif.org/vocabulary/dwc/ or reference an external link?
@timrobertson100 should we just do all this in the sandbox environment, ideally on the same branch? @tucotuco and I can coordinate
Yes, please. Feel free to do it in this PR by committing more to your branch.
@timrobertson100 do you want us to create/copy the newly adopted controlled vocabularies for these terms in http://rs.gbif.org/vocabulary/gbif/ or http://rs.gbif.org/vocabulary/dwc/ or reference an external link?
You mean sandbox or production? Everything needs to go to the sandbox first to allow testing.
To ensure we don't block anything, suggest keep new work (chrono extension) in separate PR which can be merged immediately
I didn't realize I had this other pending work not in a pull request previously. Unintentional.
Given this has no changes, should we close it and start afresh? I presume something has gone wrong with a merge.
I will try to tackle this before the end of the year. I might start with a new PR.
I already have these done. Will commit and make a pull request momentarily.
On Wed, Dec 16, 2020 at 5:49 AM Peter Desmet notifications@github.com wrote:
I will try to tackle this before the end of the year. I might start with a new PR.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gbif/rs.gbif.org/pull/46#issuecomment-745933942, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADQ72Z5VHKOXGZRZKNYMALSVBYDJANCNFSM4S56RSSQ .
Abandoning this pull request in favor of multiple smaller ones.
Update to Occurrence Core to include latest species establishment term additions and numerous long-neglected amendments.