peterdesmet commented 3 years ago

Note 1: for easier review, these changes are made without changing the distribution_2020-07-15 file name. Once accepted, I will copy these to a new distribution file name, leaving distribution_2020-07-15.xml intact

Note 2: These changes probably require new controlled vocabularies to be made:

See https://github.com/tdwg/dwc/pull/290 and https://doi.org/10.3897/biss.3.38084

Main changes

occurrenceStatus

Use single quotes for thesaurus link (consistent with rest)
Use new Darwin Core definition, instead of:

Term describing the status of the organism in the given area based on how frequently the species occurs.

establishmentMeans

Move up term
Use single quotes for thesaurus link (consistent with rest)
Add more examples that "introduced"
Use new Darwin Core definition, instead of:

Term describing whether the organism occurs natively, is introduced or cultivated.

degreeOfEstablishment

Add term, definition and example from Darwin Core

Minor changes

countryCode

rewrite ISO 3166 alpha 2 as ISO 3166-1 alpha-2
correct typo lcoationID to locationID

lifeStage

Remove traling space from definition
Write capital Taxon
Use single quotes for thesaurus link (consistent with rest)

threatStatus

Use single quotes for thesaurus link (consistent with rest)

appendixCITES

Use single quotes for thesaurus link (consistent with rest)

eventDate

Remove trailing space from definition

endDayOfYear

End definition with period

occurrenceRemarks

End definition with period

Remove empty line after last term

timrobertson100 commented 3 years ago

@mdoering can you please confirm these would not be breaking changes to Checklistbank? As additions, I think they would simply be ignored terms right?

mdoering commented 3 years ago

Yes, ChecklistBank does not directly use any of the XML (IPT) definitions. Its bound to the enums in the GBIF API. That enum is what matters to CLB. If we update that too CLB needs a change. But CLB is using an old release 0.84 and it's not simple to upgrade to the latest api version due to the major jackson changes. So unless we want CLB to change its fixed in time as it was. In order to change the enum we might want to branch out the last gbif-api release still using jackson 1.9