search

gbif / rs.gbif.org

GBIF machine-readable resources
https://rs.gbif.org
11 stars 13 forks source link

Provisional core and extension files for 2021-07-15 ratifications. #72

Closed tucotuco closed 2 years ago

tucotuco commented 2 years ago

Functionality (validity of XML files) depends on https://github.com/gbif/rs.gbif.org/pull/71.

Vocabulary functionality for establishmentMeans, degreeOfEstablishment, and pathway depends on the creation of those and placement in vocabulary folder. I'm happy to create those if desired, but see https://github.com/gbif/rs.gbif.org/issues/21#issuecomment-900490420.

tucotuco commented 2 years ago

@MattBlissett I will make updates to address these issues.

tucotuco commented 2 years ago

@MattBlissett I think I have fixed everything you detected.

tucotuco commented 2 years ago

That last commit I intended to new in a new branch, but I selected this one instead. That commits depends on merging https://github.com/gbif/rs.gbif.org/pull/77.

MattBlissett commented 2 years ago

I think the files are fine, but the vocabularies are in sandbox/dwc/... rather than sandbox/vocabularies/dwc/..., which will be needed so the IPT picks them up.

tucotuco commented 2 years ago

Sorry, I followed the pattern of the one production Darwin Core vocabulary - /vocabulary/dwc/basis_of_record.xml and created a dwc directory in sandbox/vocabularies.

The outdated thesaurus references to these new vocabularies will have to be updated in sandbox/core/dwc_occurrence_2021-08-16.xml where they say

http://rs.gbif.org/vocabulary/dwc/basis_of_record.xml http://rs.gbif.org/vocabulary/gbif/establishmentmeans_2020-10-13.xml http://rs.gbif.org/vocabulary/gbif/degreeofestablishment_2020-10-13.xml http://rs.gbif.org/vocabulary/gbif/pathway_2020-10-13.xml

tucotuco commented 2 years ago

It is a good time to consider the proposal in issue #73 and remove https://github.com/gbif/rs.gbif.org/blob/master/sandbox/core/dwc_event_2021-08-16.xml#L16. I did not do so.