port_types: hostname lookup problem

[olivier-stasse]

Dear Geoffrey Gibbs, In port_types.py, line 176, the path does not include the minus sign which is accepted in regular hostname. (http://www.ietf.org/rfc/rfc810.txt Assumptions 1. p. 1) Therefore any hostname containing a minus sign will invalidated calls to rtinject.

Best Regards, Olivier Stasse. P.S: Here is a possible patch:

From 9ad4351fbb56ef793f8ef7dba17fd0c787bbc618 Mon Sep 17 00:00:00 2001 From: olivier-stasse olivier.stasse@aist.go.jp Date: Wed, 3 Aug 2011 14:46:58 +0900 Subject: [PATCH] Fix wrong hostname grammar in port_types

---

rtshell/port_types.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/rtshell/port_types.py b/rtshell/port_types.py index a493ef7..95d1838 100644 --- a/rtshell/port_types.py +++ b/rtshell/port_types.py @@ -173,7 +173,7 @@ def parse_targets(targets): to use a formatter.

 '''

• regex = re.compile(r'^(?P[:\w/.]+?)(?:.(?P\w+))?(?:#(?P
  [\w.]+))?$')
• regex = re.compile(r'^(?P[:-\w/.]+?)(?:.(?P\w+))?(?:#(?P[\w.]+))?$') result = [] for t in targets: m = regex.match(t) -- 1.7.0.4

[gbiggs]

Hi Olivier,

Thanks for the bug report. I've applied your patch. Let me know if you have any further issues.