search

gbirke / rememberme

A PHP library that implements secure "Remember me" cookies
MIT License
125 stars 30 forks source link

Use a CSPRNG #11

Closed paragonie-scott closed 8 years ago

paragonie-scott commented 9 years ago

openssl_random_pseudo_bytes() has been available since PHP 5.3.0. Since the PHP 5.4 branch is now "security patches only", you can expect this to be available.

gbirke commented 9 years ago

That's reasonable, however it introduces a dependency on the openssl extension. Please resubmit your patch with a modified composer file that makes the dependency explicit. Also the README has to be reworked a bit.

paragonie-scott commented 9 years ago

It might be easier to make https://github.com/paragonie/random_compat a dependency. :)

paragonie-scott commented 8 years ago

@gbirke I believe this should work better. :)