search

gbishop / TarHeelReaderTheme

Theme for new version of Tar Heel Reader
tarheelreader.org/
5 stars 3 forks source link

Choice page menu changes size #40

Closed gbishop closed 11 years ago

gbishop commented 11 years ago

When the selection moves from item to item.

cbaykal commented 11 years ago

The change in border's size was the problem. It was hard to adjust the border-size accordingly and at the same time dictate to the user that the current list item was selected. As a workaround, I changed the "selected" class change the background of the link instead, rather than the border.

Hopefully this looks okay: http://gbserver3s.cs.unc.edu/2012/09/06/cats-90/5/

gbishop commented 11 years ago

Looks much better but we need to make the menu entries coordinate with color changes. We want kids who need Red print on Black background (or whatever) to be able to see the choices.

cbaykal commented 11 years ago

You're right, I changed the menu so that it should change its background color with respect to the user's choice.

http://gbserver3s.cs.unc.edu/find/

Is this what you had in mind?

gbishop commented 11 years ago

Much better but it still loses its colors when highlighted. I think we've got to change the highlight style somehow.

On Wed, Dec 19, 2012 at 12:26 AM, Cenk Baykal notifications@github.comwrote:

You're right, I changed the menu so that it should change its background color with respect to the user's choice.

http://gbserver3s.cs.unc.edu/find/

Is this what you had in mind?

— Reply to this email directly or view it on GitHubhttps://github.com/gbishop/TarHeelReaderTheme/issues/40#issuecomment-11518068.

cbaykal commented 11 years ago

Sorry, I think I might be misunderstanding the bug.

I purposefully made the background and text change color on hover and ".selected" in order to display to the user that the current list item was either selected via the keyboard arrows or it was hovered over. If the highlighted colors were to remain the same, there would be no distinction between a selected/hovered list item, and a non-selected/hovered list item. I could certainly make the list items not lose its colors when highlighted, but wouldn't that make it impossible for the user to distinguish selected list items?

gbishop commented 11 years ago

We need to think of a way to highlight using those colors. Imagine those are the only two colors you could see.

So, we could reverse the colors to highlight. Or we could expand the border. Or maybe we should make the selected one bigger (what I was originally complaining about).

Think of the switch user kid who can only see red on black. How do we signal which one is selected for him?

On Wed, Dec 19, 2012 at 8:09 PM, Cenk Baykal notifications@github.comwrote:

Sorry, I think I might be misunderstanding the bug.

I purposefully made the background and text change color on hover and ".selected" in order to display to the user that the current list item was either selected via the keyboard arrows or it was hovered over. If the highlighted colors were to remain the same, there would be no distinction between a selected/hovered list item, and a non-selected/hovered list item. I could certainly make the list items not lose its colors when highlighted, but wouldn't that make it impossible for the user to distinguish selected list items?

— Reply to this email directly or view it on GitHubhttps://github.com/gbishop/TarHeelReaderTheme/issues/40#issuecomment-11556419.

cbaykal commented 11 years ago

Oh I see, sorry about the confusion. I think I know exactly what you mean now.

I really liked the idea with reversing the colors which to highlight. How does this look: http://gbserver3s.cs.unc.edu/find/ ?

cbaykal commented 11 years ago

The next and previous buttons should also act the same way on hover.

gbishop commented 11 years ago

Looks good.

On Wed, Dec 19, 2012 at 11:31 PM, Cenk Baykal notifications@github.comwrote:

The next and previous buttons should also act the same way on hover.

— Reply to this email directly or view it on GitHubhttps://github.com/gbishop/TarHeelReaderTheme/issues/40#issuecomment-11560079.

cbaykal commented 11 years ago

Closing this issue, can reopen if necessary.

gbishop commented 11 years ago

The highlight on the choice page at the end of books when uses switches is still using the carolina blue highlights instead of the user's choice. It works on hover but not on switch selection. Should use the same rule.

cbaykal commented 11 years ago

Should work now, could you confirm? http://gbserver3s.cs.unc.edu/find/

gbishop commented 11 years ago

good. Closing. Opening another for title.