search

gbishop / outfox

Automatically exported from code.google.com/p/outfox
Other
1 stars 0 forks source link

URL's not escaped before transmission #3

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Pass in a URL containing spaces. Note that the spaces just get passed
through instead of properly getting encoded to %20. 

Probably a bug in client side js.

Original issue reported on code.google.com by piisnear...@gmail.com on 28 Jul 2008 at 3:20

GoogleCodeExporter commented 9 years ago 
Maybe this isn't a defect? Possibly instead my buggy usage. We've got to think 
about
what *should* happen. I'm passing in a complete URL. One could argue that it 
should
already be escaped.

Original comment by piisnear...@gmail.com on 28 Jul 2008 at 4:08

GoogleCodeExporter commented 9 years ago 
Need to make this jive with caching fix too. Want the URL that will serve as 
the key
to the cache.

Original comment by c...@unc.edu on 30 Jul 2008 at 2:06

GoogleCodeExporter commented 9 years ago

Original comment by c...@unc.edu on 30 Jul 2008 at 11:18

GoogleCodeExporter commented 9 years ago 
I think the caller needs to be responsible for escaping URLs. The justification 
is
that lookups in the browser cache only seem to succeed on *exact* matches. For
instance, http://www.foobar.com/la != http://foobar.com/la !=
http://www.foobar.com/de/../la. The caller should be the one to explicitly 
dictate
exactly what gets passed for matching, even if it means extra work of escaping 
URLs.

Original comment by c...@unc.edu on 5 Aug 2008 at 1:32

GoogleCodeExporter commented 9 years ago

Original comment by c...@unc.edu on 7 Aug 2008 at 12:49