search

gbl / AntiGhost

Mod that requests the server to send surrounding blocks to you, to get rid of ghost blocks
MIT License
28 stars 16 forks source link

Capitalize "Requesting resend of blocks around you" and move it to the action bar #18

Closed OneYellowLemon closed 3 years ago

OneYellowLemon commented 3 years ago

Capitalize "Requesting resend of blocks around you" message and move it to the action bar to avoid cluttering chat. In my opinion, the message looks much better in the action bar, and then it doesn't stick around clogging up your chat. I also capitalized any message that didn't start with a capital letter.

OneYellowLemon commented 3 years ago

@gbl Would you be able to take a look and accept/reject this PR?

gbl commented 3 years ago

I basically agree with the request, moving the text from chat to the action bar is a good idea. There will be some players who won't notice the action bar and complain that "nothing happens anymore", but I guess you can't accomodate everybody.

As to the translation texts, their "source" is on crowdin.com, and the language files will get overwritten with each gradle downloadTranslations run which is part of the build process. So, I'll accept the PR as it is right now, but expect the capitalization to disappear unless the crowdin translations get updated as well.

OneYellowLemon commented 3 years ago

Ah, got it. I'll go see if I can update them on Crowdin.

OneYellowLemon commented 3 years ago

@gbl Turns out someone has already suggestion to capitalize them on Crowdin.