search

gbl / AntiGhost

Mod that requests the server to send surrounding blocks to you, to get rid of ghost blocks
MIT License
28 stars 16 forks source link

Merge forge and fabric #38

Closed AnimalsWritingCode closed 1 year ago

AnimalsWritingCode commented 1 year ago

Summary

This PR merges together the forge and fabric branches into one project with a common module. The forge and fabric modules now only hold the event subscribing logic so they are pretty minimalistic. If the architectury API is used, even that could be reduced but I leaned in favor of not adding any dependencies since the benefit is pretty minor for this project.

My hope is this eases maintaining the project for both versions and makes a simpler branching structure in git.

Dependencies

It uses the architecture forge-fabric template as a foundation but does not rely on the API or add runtime mod dependencies.

crowdintranslate plugin

The crowdintranslate downloadTranslations task always downloads to the root project instead of the common module, so I had to keep them there and add the directory to the common module.

Mappings

Since this version uses the yarn mappings even in the forge project, the naming there had to be updated.

Base branch

This PR is based off the branch from #37 with the 1.19 branch merged in so it should cleanly merge to 1.19 and work as a base branch for both versions.

Relies on https://github.com/gbl/Versionfiles/pull/5 for the forge_version property.

AnimalsWritingCode commented 1 year ago

Going to just go ahead and close this since it isn't going to be accepted.