search

gbl / EasierVillagerTrading

This is a client side Minecraft mod that allows one-click-trades with villagers. Great if you sell double chests of food to farmers, or sugar cane to librarians.
MIT License
24 stars 19 forks source link

Fabric 1.20.1 #49

Closed adsbhatial closed 1 year ago

adsbhatial commented 1 year ago

Updating the mod to 1.20.1 since it was broken in 1.20

Creating a PR for merge to 1.19 because no 1.20.1 branch exists. If you create one I can create a PR for that instead of 1.19

Changes: In BetterGuiMerchant.java, Replaced method areItemStacksMergeable to ItemStack.canCombine since ItemStack.isNBTEqual doesn't exist anymore in 1.20. canCombine does the same job as areItemStacksMergeable

Updated gradle settings to include latest versions and changed some deprecated stuff.

Note: - Settings are still broken because gbFabricTools needs a rewrite for 1.20. DrawableHelper was replaced by DrawContext. A lot of overrides don't work since the parents don't have the methods anymore.

https://fabricmc.net/2023/05/25/120.html

Also created a separate PR for version files here

gbl commented 1 year ago

Thank you. Not merging as I updated many of my mods, including this, before I realized there is a pull request, but thanks anyway.