search

gbm-developers / gbm3

Gradient boosted models
133 stars 117 forks source link

Suggest adding "build_vignettes = TRUE" to "devtools" install instructions. #162

Closed jasmyace closed 4 months ago

jasmyace commented 4 months ago

I see your gbm3 repo includes vignettes. Unfortunately, after your devtools-instructed install, I could not find them locally (on my Mac). That is to say, I ran 

library("devtools")
install_github("gbm-developers/gbm3")

browseVignettes("gbm3")

and came up empty.

To remedy, I reinstalled, explicitly setting build_vignettes = TRUE (and force = TRUE to force a re-install) 

library("devtools")
install_github("gbm-developers/gbm3", build_vignettes = TRUE, force = TRUE)

browseVignettes("gbm3")

I now see the four vignettes. Assuming my experience is not unique, a slight instruction update on your landing-page README may aid the more casual installer.

gregridgeway commented 4 months ago

Good suggestion. Fixed