search

gboeing / osmnx-examples

Gallery of OSMnx tutorials, usage examples, and feature demonstations.
https://osmnx.readthedocs.io
MIT License
1.52k stars 521 forks source link

Make osmnx samples usable with Binder #17

Closed jaakla closed 6 years ago

jaakla commented 6 years ago

Possible fix for https://github.com/gboeing/osmnx/issues/182

The "Binder" badge in readme should be adjusted for the main repo URL.

rhiever commented 6 years ago

Funny, I was about to submit this PR. Shouldn't the extra required packages (e.g. matplotlib, pandas) be added to the Binder dependencies as well?

jaakla commented 6 years ago

I assume these come via dependency tree anyway.

rhiever commented 6 years ago

I just tested in Binder and the necessary dependencies appear to come via the dependency tree, as you assumed. The advantage of explicitly stating the dependencies in the environment.yml may be that the more standard libraries will come via the default conda channel instead of conda-forge, but that's not a huge deal I think.

gboeing commented 6 years ago

@jaakla @rhiever thanks guys!