search

gboisse / gfx

A minimalist and easy to use graphics API.
MIT License
502 stars 36 forks source link

Add functions to resize existing textures. #105

Closed maoliver-amd closed 8 months ago

maoliver-amd commented 8 months ago

Does what it says on the title. This makes it easier to resize textures as it automatically handles copying over texture name and other parameters (technically doesnt copy them as it just reuses them). This also fixes an issue whereby the clear value is not user accessible so theres no easy to recreate a texture using the set clear value. With these new functions that is now fixed as the clear value is copied over from existing texture when resizing.

gboisse commented 8 months ago

What about making the clear value part of the GfxTexture object (with the corresponding getter) then have these "re-create" functions as part of the application? They wouldn't need any internal gfx access then.

maoliver-amd commented 8 months ago

What about making the clear value part of the GfxTexture object (with the corresponding getter) then have these "re-create" functions as part of the application? They wouldn't need any internal gfx access then.

There are currently 2 locations in gfx that work purely with the internal Texture without knowing what the corresponding public facing GfxTexture object is. Moving the clear value from internal to public would cause an issue here as there doesnt seem to be an easy way to get the GfxTexture from a Texture. So it required duplicating the clear value in both GfxTexture and internal Texture