gboisse / gfx

A minimalist and easy to use graphics API.
MIT License
502 stars 36 forks source link

Update submodules #45

Closed maoliver-amd closed 2 years ago

maoliver-amd commented 2 years ago

Updates submodules to latest version with any required changes.

D3D12MemoryAllocator: v2.0.1 imgui: v1.62 tinyobjloader: v2.0.0rc9

gboisse commented 2 years ago

Mmh the version is the names is a bit on purpose so we can immediately see what version is being used for each dependency. It does make the updating slightly more painful I suppose, but I also think it makes it much clearer/more explicit what's the state of the dependencies?

maoliver-amd commented 2 years ago

Mmh the version is the names is a bit on purpose so we can immediately see what version is being used for each dependency. It does make the updating slightly more painful I suppose, but I also think it makes it much clearer/more explicit what's the state of the dependencies?

Yeah I figured as much. Just running git submodule from the gfx folder though also gives the complete list of submodule versions. So Im not sure which results in less work, running git submodule to check the current versions or renaming the folders everytime the submodule is updated.

The names are just the default here as in the texture_compression PR the names were just using the default (as I didnt change them from what git submodule add makes so I just did the same thing here (actually deleted the older folders and made new ones using the default as git went a little silly with whatever I did when I renamed the existing folder)

gboisse commented 2 years ago

Yeah I figured as much. Just running git submodule from the gfx folder though also gives the complete list of submodule versions. So Im not sure which results in less work, running git submodule to check the current versions or renaming the folders everytime the submodule is updated.

Yea, you're right, didn't know about this. The version numbers don't even match although I did use the commit tagged for each release 😄