search

gboisse / gfx

A minimalist and easy to use graphics API.
MIT License
498 stars 35 forks source link

New glTF importer crashes when objects have no valid name #49

Closed gboisse closed 2 years ago

gboisse commented 2 years ago

So, it seems that cgltf returns nullptr names on objects that have no valid name, which crashes std::string as they do not accept nullptr assignments (which is a really annoying thing if you ask me): https://github.com/gboisse/gfx/commit/c31f5ceebf2b54a83c3c982cde0c6b6c5865fc81 (could cause the crash by trying to load the Sponza scene)

This ticket is mostly to track whether you think there's other places where this check should be added?

maoliver-amd commented 2 years ago

Side effect of having multiple sponza scenes, I clearly tested the wrong one.