search

gboudreau / sabconnectplusplus

SABnzbd extension for Google Chrome
GNU General Public License v3.0
77 stars 45 forks source link

Dognzb Quick-Download Button also downloads nzb #106

Closed nickwolf closed 10 years ago

nickwolf commented 10 years ago

Lately, whenever I press the Sabconnect++ added download button on Dognzb, the .nzb file also downloads.

ryanwelka commented 10 years ago

Same started happening to me about a day or two ago..

We should ask DOGnzb about link format changes they may have made. It looks like SABconnect++ was last updated in late 2013.

ppslim commented 10 years ago

Looking at the way dognzb is implicated, it seems simple enough. They used to use the onclick event for their download, which suggests they have changed this to something else.

I can't however check specifics, as I am not registered there.

D0MF commented 10 years ago

[edited] ppslim, invite is in your email.

ppslim commented 10 years ago

Got it.

However... the problem appears to be the caused by way Chrome handles badly presented DOM, but the core problem is the dognzb site is sending back malformed HTML :(

The DIV element is missing an ending > character.

As a result, the jquery used to render the sab++ icon starts to treat the next html tag (a td) as part of the div. This is clearly breaking things.

Will report to the site, but play with what options are available to un-break it in the extension

ppslim commented 10 years ago

So the solution is in and tested.

It will replace the div now rather than edit it in situ.

I use an old version Chromium on my dev box, which didn't suffer from the problem. Looking at the rendered HTML, it looks like a change was made recently in Chrome itself, that causes it to act differently in this bad rendering (which also means the problem in dognzb has actually been there quite some time)