search

gboudreau / sabconnectplusplus

SABnzbd extension for Google Chrome
GNU General Public License v3.0
77 stars 44 forks source link

Fix for autoscrolling webpages #179

Closed kbuffington closed 4 years ago

kbuffington commented 4 years ago

Yahoo, and several other pages would auto scroll due to an issue in jQuery when the user scrolled them down from the top window (i.e. they'd keep scrolling down). You can reproduce here: https://angular.io/guide/http by scrolling down a bit and watching it continue on.

Bumping up to jQuery 1.9.1 makes the problem go away. Couldn't bump to latest jQuery as it seems to break other things.

Fixes: #169 Fixes: #154

gboudreau commented 4 years ago

Pending review from Google; that's a new one: image

ppslim commented 4 years ago

This was introduced around the time of the prior tag in April.

One of the more obvious permissions being requested causes this *://*/*, but also tabs. By their very nature, they provide scope for how some of the more unsavoury extensions do their own magic.

This is something I remember thinking may need to be looked at when they announced it. I know why we needed the permissions when I added them for the auto-detect, but they may not be as required now (e.g. activeTab could possibly provide a favourable alternative as it can be triggered by a browser action)

The following is worth a read https://developer.chrome.com/apps/permission_warnings