search

gboudreau / sabconnectplusplus

SABnzbd extension for Google Chrome
GNU General Public License v3.0
77 stars 44 forks source link

Firefox support #185

Open bertvandepoel opened 3 years ago

bertvandepoel commented 3 years ago

So I've moved from chromium to firefox some time ago, but I really miss having a decent nzb extension. So I plugged the crx into https://www.extensiontest.com and figured out porting it was trivial. Basically I changed all occurrences of chrome.extension.sendMessage to chrome.runtime.sendMessage and all occurrences of chrome.extension.onMessage to chrome.runtime.onMessage. This is also advised by Google itself, as the chrome.extension versions are seemingly being deprecated at some point. Now I can easily make a pull request to get those fixes into the code, but I was wondering if you would be willing to submit the extension to addons.mozilla.org. It seems kind of rude if I would do it instead of you, as it remains primarily your extension. I'm also not too sure if you've automated the process for the chrome store and could just do the same for mozilla addons. Let me know what has your preference!

bertvandepoel commented 3 years ago

After waiting for a while, I've forked the project to https://github.com/bertvandepoel/sabconnectplusplus and submitted it to AMO. It's available on https://addons.mozilla.org/en-GB/firefox/addon/sabconnect-for-firefox/

I'm happy to transfer ownership to you, for you to add a link to AMO, or any other solution you may suggest so both chrome/chromium and firefox users can enjoy the convenience of SABconnect++.