OTP-19 and openssl 1.0.x compatibility

gbour / letsencrypt-erlang

Let's Encrypt client library for Erlang

Apache License 2.0

52 stars 16 forks source link

OTP-19 and openssl 1.0.x compatibility #16

Closed mworrell closed 2 years ago

mworrell commented 4 years ago

This changes a couple of things:

Sets min OTP version to 19, as it does indeed work excellent with OTP-19
Uses the openssl 1.0.x code to add the SANs to the certificate, as quite some machines are still using a late version of openssl 1.0.x
Enables the Dialyzer Makefile target
Small start with additional typing of arguments

gbour commented 4 years ago

Hi @mworrell Thanks for your valuable contributions. I will review this MR quickly

mworrell commented 4 years ago

Merged fixes.

mworrell commented 4 years ago

@gbour could you have another look?

I also added:

Support for SANs using slave mode
Replace Jiffy with JSX to fix problems with compilation on OTP-23
Renamed letsencrypt_api:order/4 and order/5 to get_order/4 and new_order/5

mworrell commented 4 years ago

Hi @gbour. GitHub doesn't show me clearly what changes you requested are still open. Could you have a look?

mworrell commented 4 years ago

Hi @gbour, do you have time to have a look at this?

mworrell commented 3 years ago

Ping :)

Olivier-Boudeville commented 3 years ago

Hi Marc, thanks for these improvements that, as I understand, could not be (yet) integrated here (FWIW, I took inspiration from them for https://github.com/Olivier-Boudeville/Ceylan-LEEC - at least for the SAN certificates); thanks to you and Guillaume for bringing ACME support to the Erlang community!

mworrell commented 3 years ago

Hi @Olivier-Boudeville, thanks for the nice words, and good to know that this code is of good use for others as well. As for the pending status of this request, I guess that @gbour is very busy with other things at the moment.