gbouras13 / hybracter

Automated long-read first bacterial genome assembly tool implemented in Snakemake using Snaketool.
MIT License
107 stars 8 forks source link

snakemake incompatible to the provided slurm profile #55

Open zhanxw opened 9 months ago

zhanxw commented 9 months ago

Describe the bug In snakemake (v8.4.7), "--cluster-status" is not supported, and thus the "cluster-status" in config.yaml will not work.

For more details on this (or incompatible between snakemake and profile), see: hybracter

aforestsomewhere commented 7 months ago

It seems possible to use the new cluster-executor plugins with Hybracter with a few tweaks, that is working in my hands on the test data.

To add to requirements/recipe (I installed these into the virtual conda environment in which I have installed hybracter):

config.yaml to be renamed to config.v8+.yaml and contents updated:

Sharing in case it is helpful - probably worth testing on other HPC setups (for example I have issues with the sacct command in snakemake workflows locally so could not test the slurm_status.py checker)

gbouras13 commented 7 months ago

Hi @aforestsomewhere ,

Do you mind if I add this to the documentation eventually - thanks so much for this!

George

aforestsomewhere commented 7 months ago

Hi @aforestsomewhere ,

Do you mind if I add this to the documentation eventually - thanks so much for this!

George

Of course, glad it was somewhat useful!

Katie

momsane commented 1 week ago

Hi, I was wondering if the latest versions of Hybracter now account for how snakemake v8 uses plugins instead of profiles? I see that in version 0.9.0 snakemake-interface-common, snakemake-interface-executor-plugins, snakemake-interface-report-plugins, snakemake-interface-storage-plugins and snakemake-minimal are included, but not snakemake-executor-cluster-generic and snakemake-executor-plugin-slurm.