Closed incoherentian closed 11 months ago
Hi @incoherentian ,
Thanks for this suggestion - it shouldn't be too hard to implement. I'll be very happy to support input to dragonflye, it's a great tool like everything else Robert creates :)
I would certainly recommend running Plassembler instead of Unicycler for your usecase (it's the exact reason why I made it!).
I'll add it with #36 in the next version for v1.3, I'm just waiting to check what Jan wanted in that issue. It should be trivial to implement this.
Also, you might want to try my tool Hybracter https://github.com/gbouras13/hybracter especially if you have multiple isolates, it comes built in with plassembler and a few other things (and it is why I made --flye_directory
in the first place).
George
Hi @incoherentian ,
I've implemented this in v1.3.0. Let me know if you have any issues.
George
Thanks!
Something weird occurring with my first try:
Hi @incoherentian ,
That is a strange bug indeed - I can't replicate it in my tests.
I would guess it is because the flye output contig names in the info file don't match the contig headers in the FASTA (because dragonflye changes this ?)
Anyway, the bug is caused by some bad code from me - I've made a fix that should hopefully fix the issue regardless.
It's on the dev branch if you are keen to try.
George
I had a go! An unsuccessful one...
The TL;DR is that I tried to install the dev build using pip within a new conda env for aforementioned test, but this results in:
[c.medib@cl2(hawk) plassembler]$ pip install -e .
WARNING: Value for scheme.headers does not match. Please report this to <https://github.com/pypa/pip/issues/9617>
distutils: /apps/languages/mambaforge/4.10.1/el7/include/python3.9/UNKNOWN
sysconfig: /apps/languages/mambaforge/4.10.1/el7/include/python3.9
WARNING: Additional context:
user = False
home = None
root = None
prefix = None
Defaulting to user installation because normal site-packages is not writeable
ERROR: File "setup.py" or "setup.cfg" not found. Directory cannot be installed in editable mode: /nfshome/store02/groups/scw1940/.conda/envs/plassembler-dev20231027/bin/plassembler
(A "pyproject.toml" file was found, but editable mode currently requires a setuptools-based build.)
No judgment here Ian, sometimes I cant even get my own programs to install!
Pleasingly this has an easy fix. v1.4.0 incorporates this change is out on conda, so I’d just make a brand new environment with it.
George
Is your feature request related to a problem? Please describe. I would like to try using plassembler with dragonflye outputs, without wasting compute on rerunning flye in plassembler.
Describe the solution you'd like Would it be feasible to allow e.g.
rather than having to rerun flye or make temp copies hopefully-concordant with standard flye output e.g.
...for
--flye_directory
Describe alternatives you've considered Perhaps this is the alternative (to what I currently do, follow up every dragonflye-mediated flye assembly with a full unicycler assembly)?
Thanks for openly sharing your plasmid recovery tool, either way!