gbowne1 / RadioLogger

A Radio Logging application build with NodeJS and ExpressJS
GNU General Public License v3.0
6 stars 7 forks source link

[BUG] Some pages have CORS errors still #53

Closed gbowne1 closed 1 year ago

gbowne1 commented 1 year ago

Navigating to /dashboard then clicking on the button to each of the pages from the card(s) shows that some of the html files like scanlog.html give CORS errors to the jquery, font-awesome, bootstrap and popperjs libraries.

We should consider downloading and these libraries on the client side package.json in the future and removing the CDN links

The other pages that are experiencing this are:

jzunigarce commented 1 year ago

I can correct the links on each of the pages, but the error occurs, for example, in bootstrap because you are using different CDNs and different versions. In the dashboard page you use version 5.2 of cdnjs.cloudfrare and in hamlog you use version 5.2.3 of https://cdn.jsdelivr.net/

jzunigarce commented 1 year ago

The url of page are localhost:3000/page. Example: http://localhost:3000/hamlog/, http://localhost:3000/contestlog. If any route is missing please let me know, the idea is to define the routes in the router folder and not in server.js

gbowne1 commented 1 year ago

I am goimg to fix the CDNs today.

We should actually be using downloaded assets instead of CDNs but will fix those today.

gbowne1 commented 1 year ago

I think my push today should fix most of them. I cleaned up the link tags and script tags using the working ones from the dashboard.html

gbowne1 commented 1 year ago

Closing this as fixed