search

gbowne1 / ShopMRP

A MRP application for Job Shops, Machine Shops and Fabrication shops.
MIT License
6 stars 1 forks source link

[BUG] In /src/App.js useStyles / makeStyles is depr. #3

Open gbowne1 opened 1 year ago

gbowne1 commented 1 year ago

Description

useStyles & makeStyles is deprecated in @mui 5

Remove this styling and add .css files instead.

Screenshots

No response

itspunkaj commented 1 year ago

hey did you try using migration to tss-react

itspunkaj commented 1 year ago

i think i can help in this. Let me know the how to contribute.

gbowne1 commented 1 year ago

The styling could be moved to App.css instead. I don't even know what tss-react is. I am using MUI here.

I wanted to make compoment css for Drawer and the navigation.

If you want to work on it, go ahead.

itspunkaj commented 1 year ago

you just want the makestyles css to work right ???

gbowne1 commented 1 year ago

It's deprecated.. it can just be removed. @mui/styles and @mui/material/styles are both deprecated, so they won't work.

The styling should ideally be moved to individual CSS files. These ones were for the Drawer component and the top navbar, exported from MUI as AppBar, Toolbar...

https://mui.com/material-ui/react-app-bar/https://mui.com/material-ui/react-app-bar/ https://mui.com/material-ui/react-drawer/

gbowne1 commented 1 year ago

if you think tss-react could fix it, I am open to options here.

itspunkaj commented 1 year ago

hey i have solved the issue of makeStyles but now it shows some useContext issue. Was it already there ??

itspunkaj commented 1 year ago

@gbowne1

gbowne1 commented 1 year ago

Not that I know of @itspunkaj . Feel free to PR what you have.

itspunkaj commented 1 year ago

um lemme check it i'll PR in hour or so

gbowne1 commented 1 year ago

No rush. Am not at my PC rn. I can review when I get back. I need to add the TÒDO issues today as well as there are missing some of the pages and their components.

itspunkaj commented 1 year ago

okay