32 todo bug clicking on any of the commands doesnt do anything yet

gbowne1 / TwitchBot

A MERN full stack TwitchBot

MIT License

7 stars 10 forks source link

32 todo bug clicking on any of the commands doesnt do anything yet #62

Closed jarmentor closed 7 months ago

jarmentor commented 7 months ago

Opening a PR for #32

This PR:

adds responsive styling to the CommandList grid
modifies tests for the CommandList grid to account for card component abstraction
proposes an approach for adding command functionality in a modular way
adds tests for the format of the array of commands.
adds tests for the CommandCard component

Note: This does not address the later comment in the issue regarding the weather command connecting to a public weather API (would this be a separate issue; I'm happy to add it here?)

When reviewing: you may need to unprotect the /commands route

All tests pass.

gbowne1 commented 7 months ago

@jarmentor

Would it be possible to make this so that added commands get dynamically updated to the UI without having to go in each time and update the list in the commands panel?

jarmentor commented 7 months ago

@gbowne1 - I think yes -- but I want to be sure I'm understanding your meaning. Added on the server and then automatically reflected in the client?

gbowne1 commented 7 months ago

Yes thats what I was thinking about @jarmentor it would reduce having to go in and manually update the array of commands. There should also be a UI feature for the streamer or any authorized and properly authenticated user, update and add commands to the bot which would also update the commands page. This should also be allowed in chat by mods by issue the !add or !addcommand in chat. Nightbot, Streamlabs, etc do this.