[BUG] Top Nav bar issues

gbowne1 / gbowne1site_react

React version of gbowne1 site

GNU General Public License v3.0

4 stars 12 forks source link

[BUG] Top Nav bar issues #34

Closed gbowne1 closed 12 months ago

gbowne1 commented 1 year ago

There are several issues with the blue top nav bar.

Too high, should be 60px-80px high on desktop.
Navigation and its link buttons are now invisible
Search bar also the wrong size

Other minor issues.

gbowne1 commented 1 year ago

This is how it should look.. and did for a while till it got messed up.

gbowne1_navbar

gbowne1 commented 1 year ago

@adeleke5140

adeleke5140 commented 1 year ago

thank you for the pointer @gbowne1.

I fixed all the a11y issues and tested with the Google lighthouse automated testing tool. I will send a PR you can review in 5min.

gbowne1 commented 1 year ago

No rush.

If you want to work on other issues you are welcome to.

CodeBooker reactsocialnetwork

Also few of my other projects need a11y work as well

adeleke5140 commented 1 year ago

Great. I would take a look at them as well.

gbowne1 commented 1 year ago

Great. I welcome both new filed issues and PR's. Keep in mind that it will take a minimum of 2 reviews to get a PR merged on codebooker repo, but that shouldn't be an issue. 5 successful merges and you will be invited to be collaborator.

gbowne1 commented 1 year ago

@adeleke5140 make sure you sync this repo. I pushed up a change that fixed an issue or two.

I did the Firefox accessibility tests tonight.. Still missing Clickable element Focus Styling / Keyboard on the Navbar Buttons and the Search bar

adeleke5140 commented 12 months ago

Got it. I am working on this right now.