[A11y] Fix A11y issues - Githubissues

gbowne1 / gbowne1site_react

React version of gbowne1 site

GNU General Public License v3.0

4 stars 12 forks source link

[A11y] Fix A11y issues #40

Closed gbowne1 closed 1 year ago

gbowne1 commented 1 year ago

Issues are contrast, keyboard and text labeling and are hitting these issues:

[ ] Clickable elements must be focusable and should have interactive semantics
[ ] Content with images must be labeled
[ ] Focusable element may be missing focus styling.
[ ] Does not meet WCAG standards for accessible text
[ ] Interactive elements must be labeled.

adeleke5140 commented 1 year ago

Hi @gbowne1 I have experience fixing a11y bugs, I would like to handle this and would like it if you could assign it to me.

gbowne1 commented 1 year ago

Ok @adeleke5140 I will assign you

adeleke5140 commented 1 year ago

Thanks.

adeleke5140 commented 1 year ago

I cloned the project locally and ran npm start. What I get is a blank page on localhost:3000, by any chance @gbowne1, do you know what the problem could be?

Fixed: I realized that I was on the home route. There doesn't seem to be any navigation link to other routes present. Could I ask why that is?

gbowne1 commented 1 year ago

@adeleke5140

This app/site is messed up completely

I don't know why. There is a navigation bar and menu at the top but it has gotten all messed up. At one point it was rendering fine, but after a push/merge that was made it no longer didnt.. and I have not been able to figure out what broke it.

gbowne1 commented 1 year ago

If you hover over blank areas of the blue and white area in places, you might find theres hidden items like links.

The navbar on desktop should be no more than 80-100px high and I preferred 65px high.

gbowne1 commented 1 year ago

There is a comment in issue #34 that' show what it should look like.

adeleke5140 commented 1 year ago

I noticed there are a lot of bugs, some if it are caused by MUI but we would have to potentially dig deeper to fix it.

gbowne1 commented 1 year ago

Yeah this app has a number of issues. Feel free to make or file any issues in the issues tab on GitHub that you find.

adeleke5140 commented 1 year ago

Got it. I just pushed a PR for the a11y errors.

Would it be possible for you to add the hacktoberfest label to the issues. It could also incentive other people to help out.

gbowne1 commented 1 year ago

I am not in front of my PC at the moment, but will do so as soon as am able.

My Primary goal is to work on CodeBooker and ReactSocialNetwork aka reactsocialnetwork.

https://github.com/gbowne1/reactsocialnetwork and https://github.com/gbowne1/CodeBooker

gbowne1 commented 1 year ago

@adeleke5140 I went and added the label to CodeBooker and ReactSocialNetwork and I also reviewed and merged your PR. Will look deeper when I get back to the PC later today.

adeleke5140 commented 1 year ago

That's great. I will take a look at the other repos as well.