search

gbowne1 / gbowne1site_react

React version of gbowne1 site
GNU General Public License v3.0
4 stars 12 forks source link

Fix/top nabar issues #43

Closed adeleke5140 closed 12 months ago

adeleke5140 commented 12 months ago

This PR will fix the issues with the navbar. It was noted that the height was unusually large, and I have worked on making that look how it used to be.

Rather than use an explicit height value, I opted for the padding value instead.

Here is how it looked before:

Screenshot 2023-10-22 at 02 21 16

Here is how it looks now:

Screenshot 2023-10-22 at 02 21 01

This should effectively close #34

gbowne1 commented 12 months ago

hey thats awesome! Thanks @adeleke5140 I will review the PR and merge. Looks acceptable from here though!

adeleke5140 commented 12 months ago

You are welcome. I have got some time this Sunday, so I will help solve a bunch of issues you've got.

gbowne1 commented 12 months ago

yeah, feel free to work on whatever you like @adeleke5140 . Just let me know what youre working on and comment on the issue so I can assign. I always invite people to look for bugs/errors/warnings, etc. and do testing and post what they find so we can triage working on them.