Dark Mode contrast between nav bar and body

gbowne1 / spmssite

The code for my old business website.

GNU General Public License v3.0

8 stars 31 forks source link

Dark Mode contrast between nav bar and body #102

Closed gbowne1 closed 1 year ago

gbowne1 commented 1 year ago

Prerequisites

[X] I have read the Contributing Guidelines.
[X] I agree to follow the Code of Conduct.
[X] I have searched for existing issues that already report this problem, without success.

Current Behavior

There is not enough contrast between the navbar and body when in Dark Mode. You can barely tell where the bottom of the nav bar is

Expected Behavior

More contrast.

Steps to Reproduce

Try it.

Pathholder1806 commented 1 year ago

Hey @gbowne1 ! I would like to look into the issue!

Pathholder1806 commented 1 year ago

@gbowne1 ! I looked up into the issue and I would like to contribute to it!

So looking into the issue there are 2 possible solutions for adding the contrast:

Make the navbar more darker than the body.
Make the navbar slightly lighter than the body. Which one would you prefer so that we can move ahead

This is when we move navbar background one shade lighter than the body

This is when we move to the darker shade

gbowne1 commented 1 year ago

Sure,

I would prefer the darker shade, but that may need some A vs B testing for some end users.

Pathholder1806 commented 1 year ago

Hey @gbowne1 ! So let me generate the Pr with my proposed darker shade and then we can make further updates.

gbowne1 commented 1 year ago

I would wait till the next merge is complete.. unless there would be no merge conflicts.

Pathholder1806 commented 1 year ago

Hey @gbowne1 ! My branch went into a merge conflict. Are there any other changes coming from another merge ?

gbowne1 commented 1 year ago

Yes. I added the major changes I did today after some testing which just finished. Go back and sync.

gbowne1 commented 1 year ago

I sent you an invite too/

If you didn't get it let me know.

Pathholder1806 commented 1 year ago

Yes I received the invitation. Thank you! I synced my branch now shall I create a PR again ?

gbowne1 commented 1 year ago

Yeah, Please do. I also sent an invite to my org. there are projects there to work on if you like.

Pathholder1806 commented 1 year ago

Hey @gbowne1 ! Generated the PR. Kindly review my proposed changes and suggest any further updates if any!

gbowne1 commented 1 year ago

Review done and merged. Looks good.

If you didn't get it.. go here: https://github.com/orgs/taotnpwaft/teams and request to be on a team including member.

Thanks for the PR!

gbowne1 commented 1 year ago

Quite a bit of testing still needs done with this particular project.

The new view looks pretty good

Pathholder1806 commented 1 year ago

Always up for lending a helping hand🤝🏻

gbowne1 commented 1 year ago

There's plenty to do. I have a new issue with the about page.. notice how the content scrolls above the jumbotron/hero and navbar.

gbowne1 commented 1 year ago

Don't see a project you'd like to do in the org. I will take suggestions that will improve the community.