gbowne1 / spmssite

The code for my old business website.
GNU General Public License v3.0
8 stars 31 forks source link

Clean up the CSS or move to SCSS #104

Closed gbowne1 closed 1 year ago

gbowne1 commented 2 years ago

Prerequisites

Current Behavior

Looking through the current styles.css file it is very heavy and not very well organized.

Sort the CSS by using commented section headers in the CSS using / / i.e;

/* Body */

body {
  background: #blue;
},

/* Header */

header {
  color: #blue;
}

Thinking about this, Bootstrap 5.2 CDN sends out SCSS files so it might be handy to just convert the css to SCSS instead.

This is a more advanced task but not impossible.

Expected Behavior

Better CSS

Steps to Reproduce

Try it.

gbowne1 commented 2 years ago

Please see: #110

gbowne1 commented 2 years ago

I was thinking the other day that a number of lines in this styles.css file were meant for individual pages.

That stuff could be moved to individual files for each component and maybe even try adding a index.css for global styles like a node/express/react app would have.

A side note here: I am sure one could write a index.js or app.js to run some of the sites functions in jQuery or JS.

Rikarox commented 1 year ago

Hello, I understand what you want to achive and I would like to work on this issue, can you assigne me?

gbowne1 commented 1 year ago

Oo @Rikarox Thanks.

gbowne1 commented 1 year ago

The changes look good.

I am approving merge.