Employee Login Button & Modal

gbowne1 / spmssite

The code for my old business website.

GNU General Public License v3.0

8 stars 31 forks source link

Employee Login Button & Modal #114

Closed gbowne1 closed 1 year ago

gbowne1 commented 1 year ago

Prerequisites

[X] I have read the Contributing Guidelines.
[X] I agree to follow the Code of Conduct.
[X] I have searched for existing issues that already report this problem, without success.

Current Behavior

The added Employee Login button now works with a modal.

Needs border radius on right side of fields.
Needs some form of validation, with error messages using one of the usual PHP, JavaScript, Ajax, jQuery etc.
This needs labeled fields.
Show logged in and logged out status
More styling of the modal.

Maybe a few other things but that should get started.

Expected Behavior

Now that modal actually works make it useful as employee login.

Steps to Reproduce

Try it.

ak090498 commented 1 year ago

can I work on this ?

gbowne1 commented 1 year ago

Sure @knownasaritra

ak090498 commented 1 year ago

@gbowne1 current WIP, I am doing the validations based on a test array inside the validation script, is it fine ?

gbowne1 commented 1 year ago

@knownasaritra

Yes, that is fine.

Janvcd commented 1 year ago

Can I work on this for you??

gbowne1 commented 1 year ago

Sure

ak090498 commented 1 year ago

@gbowne1 I did these:

Needs border radius on right side of fields.
Needs some form of validation, with error messages using one of the usual PHP, JavaScript, Ajax, jQuery etc.
This needs labeled fields.
Some styling of modal
~~Show logged in and logged out status~~ , not getting logged out status, can you please explain it ?

gbowne1 commented 1 year ago

@knownasaritra thats great. Thanks.

There should be some way of show that the user has been logged out.

Here is a stackoverflow post that might help. https://stackoverflow.com/questions/10051586/how-to-log-out-showing-the-proper-status

gbowne1 commented 1 year ago

Anyone working on this, The modal also needs a cancel button.

ak090498 commented 1 year ago

I have added code for the cross button for the modal , I will add the cancel button as well

gbowne1 commented 1 year ago

Great thanks @knownasaritra

gbowne1 commented 1 year ago

@knownasaritra @Janvcd do you have a PR ready?

ak090498 commented 1 year ago

@gbowne1 I will provide by today , got busy , really sorry

Janvcd commented 1 year ago

@gbowne1 On it. Was busy in some work.

gbowne1 commented 1 year ago

Ok. Thanks.

ak090498 commented 1 year ago

@gbowne1 my pull request is drafted , please have a look , due to time constraint I could not work on the style and positioning of the logout button and the logged in status, please have a look and let me know.

gbowne1 commented 1 year ago

Merged. Thanks for the PR. @ak090498

gbowne1 commented 1 year ago

Anyone that wants to finish the work in the employee login form can do so.

ak090498 commented 1 year ago

@gbowne1 thanks for merging it's my first PR glad I could make it, btw could you give some feedback on my code

gbowne1 commented 1 year ago

@ak090498 you're welcome. I see you joined the Discord too. Feel free to contribute to our projects

https://github.com/taotnpwaft/