gbowne1 / spmssite

The code for my old business website.
GNU General Public License v3.0
8 stars 31 forks source link

Image link is broken in index.html #116

Closed SoyebSarkar closed 2 years ago

SoyebSarkar commented 2 years ago

Prerequisites

Current Behavior

The image link is broken. There is no logo.jpg file in \spmssite\src\images

image

Expected Behavior

There should be a logo.jpg file

Steps to Reproduce

Add the logo.jpg link the 'logo.jpg' path in the image tag in the index.html

SoyebSarkar commented 2 years ago

@gbowne1 I want to fix this problem

gbowne1 commented 2 years ago

Its a placeholder for an image.

You can use logoipsum.com and pick a suitable logo to use.

Either way, make sure all of the headers get logos.

SoyebSarkar commented 2 years ago

Its a placeholder for an image.

You can use logoipsum.com and pick a suitable logo to use.

Either way, make sure all of the headers get logos.

image

I have created a pr #120 @gbowne1 please review and let me know

gbowne1 commented 2 years ago

I would certainly use a logo, but not one with Logoipsum branding.

SoyebSarkar commented 2 years ago

I would certainly use a logo, but not one with Logoipsum branding.

thank you for your review @gbowne1

image image

I changed the logo, please check and let me know