included bootstrap css/script links to index.html and revised "About" button links

gbowne1 / spmssite

The code for my old business website.

GNU General Public License v3.0

8 stars 31 forks source link

included bootstrap css/script links to index.html and revised "About" button links #118

Closed SergeyKharkovshchenko closed 2 years ago

SergeyKharkovshchenko commented 2 years ago

id: [issue-link](https://github.com/gbowne1/spmssite/issues/111)
attributes:
  label: #111
  description: PR includes bootstrap in index.html and revises About button links

gbowne1 commented 2 years ago

@SergeyKharkovshchenko This has merge conflicts. Not able to merge this.

mu-irfan commented 2 years ago

@SergeyKharkovshchenko to resolve the conflict remove extra text from the code line '111', '125' and check if you put any other extra text then remove it.

gbowne1 commented 2 years ago

@developer-irfan

The only thing I see with this one is that there is already bootstrap CDN for both CSS and JS. No need to add them again. This will confuse the browser and the about links are just fine so I would not change them. This PR can just be closed.

SergeyKharkovshchenko commented 2 years ago

Hi, just to make sure, are you closing this PR?