gbowne1 / spmssite

The code for my old business website.
GNU General Public License v3.0
8 stars 31 forks source link

Dark Mode does not persist between same page #130

Open gbowne1 opened 1 year ago

gbowne1 commented 1 year ago

Prerequisites

Current Behavior

Dark mode / theme does not persist once toggled on.

Noticed this when on Contact page (contact.html). Clicked on the Contact item in the NavBar. Theme changed back to Light from Dark without having to toggle.

I assume you can persist the theme state. This might require a theme.js controller.

Expected Behavior

Persistent Dark mode or Light mode till user turns the feature on or off and changing pages does not change theme mode.

Theme should not change between pages, in other words, the mode should not turn off till the user toggles the theme switch.

Steps to Reproduce

Notice that now the dark mode turns off.

Halim-Shams commented 1 year ago

Hey, can give me some more info like, which frontend framework you are using? if you are using ReactJS I can help you with that.

gbowne1 commented 1 year ago

@Halim-Shams

This does not use a framework of any kind.