search

gbowne1 / spmssite

The code for my old business website.
GNU General Public License v3.0
8 stars 31 forks source link

Add FontAwesome Social Icons #5

Closed gbowne1 closed 2 years ago

gbowne1 commented 2 years ago

This template site does not have any FontAwesome Social Icons either on footer or header

Either placement would be ok.

Add placeholder icons for Instagram, Facebook, LinkedIn, Yelp, Twitter, etc. so that the user can use it to add their appropriate links.

VincentWoglo commented 2 years ago

Can you assign me to this issue?

Dikshatomarr commented 2 years ago

I'm willing to work on this issue.

gbowne1 commented 2 years ago

Thank you. You can work on the issue.

gbowne1 commented 2 years ago

I have assigned both of you

gbowne1 commented 2 years ago

This issue was resolved today but here is the current render

Screenshot 2022-08-16 at 14-37-26 Seattle Precision Machine Shop

The footer still needs quite a bit of work, including styling the social icons with their respective colors. .

gbowne1 commented 2 years ago

In Firefox v103 I can only see the top 3/4 of the page and it does not scroll.

VincentWoglo commented 2 years ago

When I forked the repository, same happened on my end.

gbowne1 commented 2 years ago

Should be fixed as of now.

Make sure youre up to date. I merged changes that should take care of that issue.

Let me know. I wont be back for 3-4 more hours to test.

VincentWoglo commented 2 years ago

Just update my forked repository and I did a git pull. The problem is still there

gbowne1 commented 2 years ago

Ok. I will have a look when I get back. Its still mid day here and am not done with work yet. 2 more hours snd I will be back to look.

gbowne1 commented 2 years ago

It works, I tested it. Might be a slight problem with your local.