gbowne1 / spmssite

The code for my old business website.
GNU General Public License v3.0
8 stars 31 forks source link

Styling for jobs.html #55

Closed gbowne1 closed 2 years ago

gbowne1 commented 2 years ago

Prerequisites

Current Behavior

This needs quite a bit of styling work.

A lot of the fields are too large and a few are not the right type. Some are too close together.

It is also not ready to connect to the backend.

Expected Behavior

A nicely styled form easily able to be connected to the backend // database.

Using..

PHP, jQuery, Ajax, JavaScript...

Also test whatever scripts exist.. and write missing code.

This should also send both an email or some notificatio to both HR department and the user filling out the form that

Also most of the form needs validation script to make sure of no empty fields, incorrect information, etc.

Steps to Reproduce

Load the index.html and click on the Careers button in the menu.

Use a preview or Live Server extension to view the page.

MirandaBrawnerSavannah commented 2 years ago

I can start working on this. I'm new to this project, never contributed before, but I'll give it a try.

gbowne1 commented 2 years ago

Alright. Thanks :-)

MirandaBrawnerSavannah commented 2 years ago

I have some feedback about the content of the jobs form.

Do you think that the Date field at the top is necessary? It might make sense on a form that's printed out, but for an online form, we could use the system date from when they filled out the form.

I also think we should leave out the questions asking about someone's criminal record. Excluding people based on past legal trouble is not a good idea, because it leaves people in a trap where they can't find a job, and have no way to make a living except possibly by illegal means, which forces them back into the prison system even when they are trying to earn an honest living. Also, the criminal justice system isn't exactly fair. It's often very discriminatory, and each step of the process multiplies the discriminatory effects, from policing to bail to sentencing, etc. We don't want for employers to duplicate the unfair effects of the criminal justice system.

There are also state and federal laws that prohibit asking questions like this. Here's an article about these laws and the reasoning behind them. While there are some exceptions to some of these laws, I think it makes sense for our templates to leave them off, for the reasons above.

gbowne1 commented 2 years ago

It's a very old form that resided on my original website. So, yes, it needs a lot of work to be made current and legal.

The original form did allow us to print after it got sent to the ERP/MRP system and HR.

MirandaBrawnerSavannah commented 2 years ago

Ok. What would you like me to do about the date, then? Leave the field and auto-fill it with the current date?

gbowne1 commented 2 years ago

I don't know if it's really necessary to have the Date field. But if it's left in the form, I am all for using

<input type="date"> or <input type="datetime-local"> but it should autofill.

If we add jQuery UI from their CDN there is a nice datepicker from:

Datepicker - jQuery UI

gbowne1 commented 2 years ago

I also forgot to add Google Recaptcha

https://developers.google.com/recaptcha/docs/v3

MirandaBrawnerSavannah commented 2 years ago

Ok, thanks.

gbowne1 commented 2 years ago

The original also included a blue background that was somewhere between light and medium blue but some may want a more pleasing background.. and make them into separate cards or panels in the UI, rather than <br> and <hr>.

gbowne1 commented 2 years ago

I might even suggest to put in stub links to external sites like monster.com or indeed so that the end user can link to their job listing sites/apps.

MirandaBrawnerSavannah commented 2 years ago

Would you like me to replace all references to Seattle Precision Machine Shop in the text?

gbowne1 commented 2 years ago

Yes, please remove all reference to my old business name. Haven't named the actual template yet so just left it where it was when I stopped using it. Thanks @MirandaBrawnerSavannah

MirandaBrawnerSavannah commented 2 years ago

Sounds good. Another question: When you say it should be able to connect to the back end and send an email, do you have a back end set up yet? If not, can that be a separate pull request?

MirandaBrawnerSavannah commented 2 years ago

Also, I'm not sure I understand why this list of links is divided into 2 parts. Is there a difference between the first set of links and the second set?

Seattle Shop Links
gbowne1 commented 2 years ago

I am no longer using this site. but the database // backend work could/would be made easier if we ship a basic database // sql someone would have a easier time integrating.

As for the links those can be removed.. remnants of the old site.

MirandaBrawnerSavannah commented 2 years ago

I posted a pull request with the work I've done so far. https://github.com/gbowne1/spmssite/pull/70

gbowne1 commented 2 years ago

Alright. I will have a look. Its marked as a draft PR which arent able to be merged.

Thanks for the PR!