search

gbowne1 / spmssite

The code for my old business website.
GNU General Public License v3.0
8 stars 31 forks source link

Libraries #74

Closed gbowne1 closed 2 years ago

gbowne1 commented 2 years ago

Prerequisites

Current Behavior

There are currently two versions of jQuery library CDN's in the <head> tag:

<script src="https://code.jquery.com/jquery-3.6.0.js" integrity="sha256-H+K7U5CnXl1h5ywQfKtSj8PCmoN9aaq30gDh27Xc0jk=" crossorigin="anonymous"></script>

and

<script src="https://code.jquery.com/jquery-3.2.1.slim.min.js" integrity="sha384-KJ3o2DKtIkvYIK3UENzmM7KCkRr/rE9/Qpg6aAZGJwFDMVNA/GpGFF93hXpG5KkN" crossorigin="anonymous"></script>

The current version is 3.6. The 3.2.1 needs to be removed from the head tag Having duplicate CDN's usually will cause the browser to get confused.

Expected Behavior

No duplicate CDN's.

Steps to Reproduce

Try it and open the browser console.

gbowne1 commented 2 years ago

This the bootstrap 5.2 JavaScript CDN is also missing from the head

<script src="https://cdnjs.cloudflare.com/ajax/libs/bootstrap/5.2.0/js/bootstrap.min.js" integrity="sha512-8Y8eGK92dzouwpROIppwr+0kPauu0qqtnzZZNEF8Pat5tuRNJxJXCkbQfJ0HlUG3y1HB3z18CSKmUo7i2zcPpg==" crossorigin="anonymous" referrerpolicy="no-referrer"></script>

Also the FontAwesome 6.1.2 JavaScript CDN is missing as well..

<script src="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/6.1.2/js/all.min.js" integrity="sha512-8pHNiqTlsrRjVD4A/3va++W1sMbUHwWxxRPWNyVlql3T+Hgfd81Qc6FC5WMXDC+tSauxxzp1tgiAvSKFu1qIlA==" crossorigin="anonymous" referrerpolicy="no-referrer"></script>

mehakg867 commented 2 years ago

Can I work on it..?

gbowne1 commented 2 years ago

Sure. I will assign you.

gbowne1 commented 2 years ago

Libraries were fixed today Aug 29, 2022 to include updated and missing CDN's for Bootstrap, FontAwesome and PopperJs.

Closing this issue completed.