gbowne1 / spmssite

The code for my old business website.
GNU General Public License v3.0
8 stars 31 forks source link

updated the look of the conact us page and done minor changes to the … #79

Closed ketsebaotgizachew closed 1 year ago

ketsebaotgizachew commented 1 year ago

…other pages


name: Pull Request template description: Create a pull request to help us improve title: "[PULL REQUEST] " labels: [enhancement] assignees:

body:

ketsebaotgizachew commented 1 year ago

Looks good. Approving for merge.

I was wondering is the darkmode in the about us section really necessary, what I mean is that most websites don't have a dark mode toggle and its good having it but as what I can see it is not working well

gbowne1 commented 1 year ago

It works, just not themed very well.

Actually a lot more sites that are run by frameworks use a theme control.

There really is no great way to detect what theme the user perfers and just display the site in the users preference.. you have to have a plugin/extension for that.

Ideally, the switch would be on all pages.. starting with the index.html