search

gbowne1 / spmssite

The code for my old business website.
GNU General Public License v3.0
8 stars 31 forks source link

Bug fixes and themeing #86

Closed ketsebaotgizachew closed 1 year ago

ketsebaotgizachew commented 1 year ago

-fixed the quotes page -fixed the drop down menu and added an new one also named about us -made the drop downs navigation work -fixed the about us pages spacing -fixed the quotes page theme and made it compatible with dark mode -fixed the stiky navbar it works now

gbowne1 commented 1 year ago

The dark mode switch shows in the search bar.

pranavmadhu01 commented 1 year ago

I recommend everyone who is putting a pull request to attach an image with final results along with the result.Since it is a website all reviewers will get a better understanding when an image is attached @ketsebaotgizachew can you attach the screenshots as comment just use the snip tool and take a picture then paste it directly in to the comment.

gbowne1 commented 1 year ago

Yeah @pranavmadhu01 I need to update the Contributing guide. And that should be the same with TAOTNPWAFT

Edit: I have made that an issue in the org metadata project. https://github.com/taotnpwaft/metadata/issues/24

ketsebaotgizachew commented 1 year ago

drop-downs-working navbar-stikyness rfq page

ketsebaotgizachew commented 1 year ago

dark mode i think the dark mode still needs more refinment

gbowne1 commented 1 year ago

yeah, starting to look nice though.

As a side note: I have a whole bunch of great text to add that would be useful in about.

Accessibility is very important. Especially when choosing themes and colors.

@ketsebaotgizachew move the 'Quotes' from About to its own tab.

gbowne1 commented 1 year ago

@ketsebaotgizachew @ketse-py

Make sure you PR your changes. I saw a few commits without a PR.

Thank you.

ketsebaotgizachew commented 1 year ago

I am new to GitHub tho so you have added me so I am able to commit directly to the repository so what are the pull requests for

gbowne1 commented 1 year ago

Yes you can commit directly but you should still make pull requests from your local branch to the main branch.

Ideally you would commit your changes to your branch ketsebaotgizachew:local-change-branch and then compare the changes with main and submit your PR.

PRs keep any changes clean by requesting reviews of people within the project.

gbowne1 commented 1 year ago

Yes you can commit directly but you should still make pull requests from your local branch to the main branch.

Ideally you would commit your changes to your branch ketsebaotgizachew:local-change-branch and then compare the changes with main and submit your PR.

PRs keep any changes clean by requesting reviews of people within the project.

One should read this: https://docs.github.com/en/get-started/quickstart/github-flow

gbowne1 commented 1 year ago

https://nvie.com/posts/a-successful-git-branching-model/