gbowne1 / spmssite

The code for my old business website.
GNU General Public License v3.0
8 stars 31 forks source link

Broken Dark Mode/Light Mode Switch #99

Closed gbowne1 closed 1 year ago

gbowne1 commented 1 year ago

Prerequisites

Current Behavior

Clicking on the switch (hard to find/see) in light mode, does a really wierd 45deg'ish slide.

Screenshot 2022-09-12 at 19-07-20 Seattle Precision Machine Shop

The switch and the label also are not in close proximity and also is interfering with the search bar field.

Expected Behavior

Working

Steps to Reproduce

Try it

ramyashreeshetty commented 1 year ago

Hey, we can do two things one is to change it into a button and placing beside the search bar OR we can move it into the top position.

image

ramyashreeshetty commented 1 year ago

For a change, I guess placing it beside the search bar would be appropriate.

ramyashreeshetty commented 1 year ago

let me know if this looks appropriate. image

gbowne1 commented 1 year ago

Yeah thats a lot better

ramyashreeshetty commented 1 year ago

I sent a PR. its for the test branch do check it.

gbowne1 commented 1 year ago

Ok I will test it out.

It will be 3-4 hours from now till I am able to test.

Thanks for the PR.

If you would like other things to work on I have other issues here:

https://github.com/gbowne1/personalsite

https://github.com/taotnpwaft/website

ramyashreeshetty commented 1 year ago

Okay thanks

gbowne1 commented 1 year ago

The bottom one needs a lot of work still.

ramyashreeshetty commented 1 year ago

https://github.com/taotnpwaft/website <- u mean this one?

gbowne1 commented 1 year ago

Yes. I haven't had time to work on it.

The header.php needs to be finished

You can write it in html inside the php file and I'll finish it.

The index.html shows what the header and navbar looks like.

gbowne1 commented 1 year ago

Tested and merged back to main. @ramyashreeshetty